Created attachment 240980 [details]
MythTV log

Created attachment 240981 [details]
mythtv-frontend log

Created attachment 240982 [details]
mythplugin-mythweb log

Created attachment 240983 [details]
mythplugin-mythmusic log

Comment 5 Robert Clausecker 2023-04-08 10:34:14 UTC

Greetings and thank you for your contribution.

Is/are there changelog(s) for these updates?

Comment 6 Robert Clausecker 2023-04-08 10:36:55 UTC

Please note that "Created by" lines have been removed from all ports a while ago.  They will not be added back and I'll strip them from your patch set on commit.

Thanks for tidying up the patch file and committing this update.

Changelog is https://www.mythtv.org/wiki/Release_Notes_-_33

The only material change is:
The minimum Qt version has been bumped from 5.9 to 5.12

The following are notable MythTV changes:
FFmpeg upgraded to version 5.1
New Waveform visualisation for MythMusic
DiSEqC support for SAT>IP
Automatic channel groups per video source
Nearly 300 continued code modernization and restructuring (not in commits below)
Version 2 of the Services API is under development

Comment 8 Robert Clausecker 2023-04-08 12:51:04 UTC

Sounds great!  Do you know if MythTV works with FFmpeg 6?  There are plans to upgrade (cf. bug #261302) and it would be great if you had that on your radar.

(In reply to Robert Clausecker from comment #8)
ffmpeg version is moot as mythtv includes its own version.
Most of my time is ensuring that version gets included
before the one that gets pulled in via qt.

Comment 10 Robert Clausecker 2023-04-08 16:26:31 UTC

(In reply to Alan Hicks from comment #9)

For a future update, check if FFmpeg can be unbundled.  Dependencies should only be bundled if there is no alternative.  Same for all other bundled dependencies if any.

Comment 11 Robert Clausecker 2023-04-09 10:40:00 UTC

The build of multimedia/mythtv-frontend fails in the stage-qa stage:

====> Running Q/A tests (stage-qa)
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'share/mythtv/metadata/Music/mbutils.py'
Warning: Possible REINPLACE_CMD issues:
- - REINPLACE_CMD ran, but did not modify file contents: configure
- - REINPLACE_CMD ran, but did not modify file contents: libs/libmythtv/libmythtv.pro
- - REINPLACE_CMD ran, but did not modify file contents: bindings/perl/MythTV/Recording.pm
- - REINPLACE_CMD ran, but did not modify file contents: programs/mythtranscode/external/replex/Makefile.standalone
- - REINPLACE_CMD ran, but did not modify file contents: programs/scripts/database/mythconverg_backup.pl
- - REINPLACE_CMD ran, but did not modify file contents: programs/scripts/database/mythconverg_restore.pl
- - REINPLACE_CMD ran, but did not modify file contents: programs/mythcommflag/mythcommflag-analyze
*** Error code 1


The REINPLACE_CMD warnings are harmless, but you'll have to fix the wrong shebang.  Please fix the issue then resubmit.  See Porter's Handbook § 17.96 for how to use USES=shebangfix.

(In reply to Robert Clausecker from comment #10)
Using system ffmpeg is wip as they are eliminating and upstreaming their modifications.
https://github.com/MythTV/mythtv/issues/428

(In reply to Robert Clausecker from comment #11)
The mythtv-frontend build is the same as mythtv so I have added the missing plist entries.

USES=shebangfix added

Portlinted all four ports.

Patch updated

There appears to be a case for retiring mythtv-frontend. The configure script no longer has options for frontend and backend.
https://www.mythtv.org/wiki/Build_from_Source

Created attachment 241383 [details]
Updated patch to upgrade mythtv family to 33.1

Created attachment 241384 [details]
MythTV log

Created attachment 241385 [details]
mythtv-frontend log

Created attachment 241386 [details]
mythplugin-mythmusic log

Created attachment 241387 [details]
mythplugin-mythweb log

Comment 18 Robert Clausecker 2023-04-09 20:23:49 UTC

Thank you for the fixes.  Will proceed with a build test shortly.

Do I understand correctly that multimedia/mythtv and multimedia/mythtv-frontend now install the exact same files?  In this case I agree, we should retire one of them.  I can do this on commit with your approval, no need to submit another patch.  This would mean removing multimedia/mythtv-frontend and adding an appropriate entry to UPDATING.  I would do this in a separate commit.

If you believe this is too abrupt, we can also first deprecate multimedia/mythtv-frontend, removing it with or after the next quarter.

Comment 19 Robert Clausecker 2023-04-09 20:38:55 UTC

Your patch in attachment #241383 [details] also contains bits for graphics/wxsvg.  I'll take liberty and ignore these.

Yes, multimedia/mythtv and multimedia/mythtv-frontend install the exact same files.

Yes, please go ahead and retire mythtv-frontend.

Oops, sorry for the graphics/wxsvg fragment.

Comment 21 Robert Clausecker 2023-04-10 09:48:05 UTC

Created attachment 241397 [details]
multimedia/mythtv-frontend: remove port

Please find attached a proposed patch for removing multimedia/mythtv-frontend for review.  As you have already approved of this change, I will commit this patch in the next few days unless you have objections.

Comment 22 commit-hook 2023-04-11 23:04:41 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=214561502e5050c3af20af0609fc75a5a89704a9

commit 214561502e5050c3af20af0609fc75a5a89704a9
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-04-10 09:42:52 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-04-11 23:02:42 +0000

    multimedia/mythtv-frontend: remove port

    The mythtv frontend is no longer built separately, obsoleting this port.
    Users should just install multimedia/mythtv instead.

    Approved by:    ahicks@p-o.co.uk (maintainer)
    PR:             270344

 MOVED                                       |    1 +
 multimedia/Makefile                         |    1 -
 multimedia/mythtv-frontend/Makefile (gone)  |   11 -
 multimedia/mythtv-frontend/pkg-plist (gone) | 4442 ---------------------------
 multimedia/mythtv/Makefile                  |   16 +-
 5 files changed, 3 insertions(+), 4468 deletions(-)

Comment 23 commit-hook 2023-04-11 23:04:44 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3c275abe771ac68aea284c473a4850a78224b4b7

commit 3c275abe771ac68aea284c473a4850a78224b4b7
Author:     Alan Hicks <ahicks@p-o.co.uk>
AuthorDate: 2023-04-08 10:37:08 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-04-11 23:02:41 +0000

    */myth*: update the mythtv family of ports to 33.1

    Selected upstream changes:

     - The minimum Qt version has been bumped from 5.9 to 5.12
     - FFmpeg upgraded to version 5.1
     - New Waveform visualisation for MythMusic
     - DiSEqC support for SAT>IP
     - Automatic channel groups per video source
     - Nearly 300 continued code modernization and restructuring (not in commits below)
     - Version 2 of the Services API is under development

    Changelog: https://www.mythtv.org/wiki/Release_Notes_-_33

    PR:             270344

 audio/mythplugin-mythmusic/Makefile                |  13 +-
 audio/mythplugin-mythmusic/distinfo                |   6 +-
 .../files/patch-settings.pro (new)                 |  11 +
 multimedia/mythtv-frontend/pkg-plist               | 505 +++++++++++----------
 multimedia/mythtv/Makefile                         |  16 +-
 multimedia/mythtv/distinfo                         |   6 +-
 .../files/extrapatch-programs_programs.pro (gone)  |  24 -
 multimedia/mythtv/files/patch-configure (gone)     |  11 -
 ...FFmpeg_libswscale_ppc_yuv2rgb__altivec.c (gone) |  11 -
 ...h-libs_libmyth_audio_audiooutpututil.cpp (gone) |  14 -
 .../patch-libs_libmyth_audio_eldutils.cpp (gone)   |  17 -
 ...libs_libmythtv_io_mythavformatwriter.cpp (gone) |  11 -
 ...mythtv_recorders_NuppelVideoRecorder.cpp (gone) |  19 -
 multimedia/mythtv/files/pkg-message.in             |   6 +-
 multimedia/mythtv/pkg-descr                        |   4 -
 multimedia/mythtv/pkg-plist                        | 458 +++++++++----------
 www/mythplugin-mythweb/Makefile                    |   5 +-
 www/mythplugin-mythweb/distinfo                    |   6 +-
 18 files changed, 513 insertions(+), 630 deletions(-)

Comment 24 Robert Clausecker 2023-04-11 23:06:53 UTC

Thank you for your contribution.