Bug 270374 - games/adom: resurrect to version 3.0.6
Summary: games/adom: resurrect to version 3.0.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-20 21:37 UTC by Volodymyr Kostyrko
Modified: 2023-10-05 11:01 UTC (History)
3 users (show)

See Also:


Attachments
resurrect 3.0.6 (2.70 KB, patch)
2023-03-20 21:37 UTC, Volodymyr Kostyrko
fuz: maintainer-approval+
Details | Diff
resurrect adom patch (3.63 KB, patch)
2023-09-04 05:28 UTC, Volodymyr Kostyrko
arcade: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Volodymyr Kostyrko 2023-03-20 21:37:17 UTC
Created attachment 241021 [details]
resurrect 3.0.6

Hello.

I just restored deleted port, cleaned up copyrights, moved WWW (as intended by later ports changes), and switched to native FreeBSD binaries from Linux ones.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-04-27 00:16:04 UTC
Comment on attachment 241021 [details]
resurrect 3.0.6

Thank you for your submission.  Setting maintainer-approval to + so this gets looked at.  I can't test your submission as I don't own the game, but perhaps someone else might be able to.
Comment 2 Volodymyr Kostyrko 2023-09-03 06:56:24 UTC
Guess I have to say this a free game version, you don't need to buy it before running it.
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-09-03 10:32:20 UTC
Submit a git formatted patch. In addition to that:

- When you are adding a port you have to add an entry in >CATEGORY>/Makefile
- When you are resurrecting a port you have to remove the relevant entry from MOVED file.

And all of these files also should be going to the git formatted patches.
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-09-03 10:33:20 UTC
For a RIP port you don't need maintainer approval.
Comment 5 Volodymyr Kostyrko 2023-09-04 05:28:22 UTC
Created attachment 244624 [details]
resurrect adom patch

Oh geez, big thanks for the words of wisdom, I was kindda feeling I'm doing something wrong but wasn't aware what exactly.
Comment 6 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-09-04 05:45:25 UTC
LGTM. Will got on my next batch of commits.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-09-05 04:57:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2671ebcfbba9718c4104b58f176cb4d63f68ce9a

commit 2671ebcfbba9718c4104b58f176cb4d63f68ce9a
Author:     Volodymyr Kostyrko <arcade@b1t.name>
AuthorDate: 2023-09-04 05:47:43 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2023-09-05 04:56:11 +0000

    games/adom: Resurrect port

    PR:             270374

 MOVED                      |  1 -
 games/Makefile             |  1 +
 games/adom/Makefile (new)  | 47 ++++++++++++++++++++++++++++++++++++++++++++++
 games/adom/distinfo (new)  |  5 +++++
 games/adom/pkg-descr (new) | 11 +++++++++++
 games/adom/pkg-plist (new) |  4 ++++
 6 files changed, 68 insertions(+), 1 deletion(-)