Bug 270531 - devel/p4, devel/p4api: fix arm builds
Summary: devel/p4, devel/p4api: fix arm builds
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Craig Leres
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-30 00:09 UTC by antonfb
Modified: 2023-04-26 15:06 UTC (History)
2 users (show)

See Also:

Attachments
patch diff to disable arm optimization (394 bytes, text/plain)
2023-03-30 00:09 UTC, antonfb 		no flags Details
p4.diff - disable arm optimization - combine patch and distinfo for two ports (2.75 KB, patch)
2023-04-08 03:06 UTC, antonfb 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description antonfb 2023-03-30 00:09:40 UTC 
Created attachment 241196 [details]
patch diff to disable arm optimization

arm builds on several OS versions are failing.

Seems like there is some missing special arm optimization code in the Perforce distribution and that code special cases to turn it off.

Add OS_FREEBSD to disable arm optimization.

Add the attached patch file to the files directory of both ports (devel/p4 and devel/p4api) to fix the arm builds.

FYI: I'm the maintainer.
Comment 1 antonfb 2023-04-08 03:06:05 UTC 
Created attachment 241345 [details]
p4.diff - disable arm optimization - combine patch and distinfo for two ports
Comment 2 antonfb 2023-04-08 03:07:06 UTC 
New patch for both ports

removes devel/p4api files/* and distinfo
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-04-09 00:55:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c3c2129c94d55bb857ff2bbb07a81779efc70fd4

commit c3c2129c94d55bb857ff2bbb07a81779efc70fd4
Author:     Craig Leres <leres@FreeBSD.org>
AuthorDate: 2023-04-09 00:54:52 +0000
Commit:     Craig Leres <leres@FreeBSD.org>
CommitDate: 2023-04-09 00:54:52 +0000

    devel/{p4,p4api}: Unbreak build on arm

    Also change devel/p4api to use devel/p4 files/patches and distinfo.

    PR:             270531
    Approved by:    antonfb@hesiod.org (maintainer)

 devel/p4/files/patch-Jamrules             |  6 +++---
 devel/p4/files/patch-zlib_deflate.c (new) | 11 +++++++++++
 devel/p4api/Makefile                      |  4 ++++
 devel/p4api/distinfo (gone)               |  3 ---
 devel/p4api/files/patch-Jamrules (gone)   | 28 ----------------------------
 5 files changed, 18 insertions(+), 34 deletions(-)
Comment 4 Craig Leres freebsd_committer freebsd_triage 2023-04-09 00:58:16 UTC 
Thanks for the patches!
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-04-25 23:01:29 UTC 
You should check if you could simply unbundle the bundled zlib in which the error occurs.  It's recommended practice anyway.
Comment 6 antonfb 2023-04-26 15:06:11 UTC 
(In reply to Robert Clausecker from comment #5)
I expect a new release in May and I'm preparing to make that unbundle stuff.