Bug 270718 - sysutils/dvdisaster: Update to 0.79.10 and flavorize
Summary: sysutils/dvdisaster: Update to 0.79.10 and flavorize
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-09 11:13 UTC by Daniel Engberg
Modified: 2023-05-01 14:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bob)

Attachments
Patch for dvdisaster (21.38 KB, patch)
2023-04-09 11:13 UTC, Daniel Engberg 		no flags Details | Diff
Patch for dvdisaster v2 (21.39 KB, patch)
2023-04-09 11:46 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-04-09 11:13:05 UTC 
Created attachment 241372 [details]
Patch for dvdisaster

- Change to fork and update to 0.79.10
- Drop NLS option, it just covers a few languages and is inconsistent
- Add nox11 flavor
- Partially backport upstream changeset 25:a315fe55901a (mercurial) to allow a clean build of nox11 flavor
- Drop GCC requirement
- Rework port to follow Porters Handbook more closely and for better readability
- Enable verbose build

Poudriere bulk OK (13.1 i386, 12.4 amd64)
Very briefly tested
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-04-09 11:46:45 UTC 
Created attachment 241374 [details]
Patch for dvdisaster v2

Fix installed file name of devices.txt (previously devices.txt.in)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-04-25 09:06:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4529825f4f31604fef85cd3cc137e91385583c64

commit 4529825f4f31604fef85cd3cc137e91385583c64
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-04-25 08:46:36 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-04-25 09:05:39 +0000

    sysutils/dvdisaster: Update to 0.79.10 and flavorize

    - Change to fork and update to 0.79.10
    - Drop NLS option, it just covers a few languages and is inconsistent
    - Add nox11 flavor
    - Partially backport upstream changeset 25:a315fe55901a (mercurial) to
      allow a clean build of nox11 flavor
    - Drop GCC requirement
    - Rework port to follow Porters Handbook more closely and for better readability
    - Enable verbose build

    PR:             270718
    Approved by:    portmgr (maintainer timeout, 2+ weeks)

 sysutils/dvdisaster/Makefile                       | 84 ++++++++++++----------
 sysutils/dvdisaster/distinfo                       |  6 +-
 sysutils/dvdisaster/files/DEVICES.html.in (gone)   | 80 ---------------------
 .../files/{DEVICES.md.in => devices.txt.in}        | 29 ++++----
 .../files/patch-GNUmakefile.template (new)         | 73 +++++++++++++++++++
 sysutils/dvdisaster/files/patch-configure (new)    | 42 +++++++++++
 .../dvdisaster/files/patch-dvdisaster.h (gone)     | 24 -------
 .../dvdisaster/files/patch-icon-factory.c (gone)   | 11 ---
 .../dvdisaster/files/patch-locale_pt__BR.po (gone) | 12 ----
 .../dvdisaster/files/patch-locale_ru.po (gone)     | 12 ----
 .../patch-scripts_bash-based-configure (gone)      | 11 ---
 sysutils/dvdisaster/files/pkg-message.in           |  4 +-
 sysutils/dvdisaster/pkg-plist                      | 18 ++---
 13 files changed, 190 insertions(+), 216 deletions(-)
Comment 3 Bob Eager 2023-04-25 09:21:20 UTC 
As the maintainer, can I ask how much testing was done with gcc? (see discussion under earlier bug)

I am still examining the proposed patches, yet the bug has been closed and the update done.

I am particularly concerned that the full recovery process has been thoroughly regression tested after the compiler change.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-05-01 14:10:13 UTC 
Hi Bob,

I asked upstream about it and if regtest passes it's a high probably everything works as expected, is that something you can test?

Best regards,
Daniel