Bug 270732 - ftp/tnftp: Add mirrors and switch to DISTVERSION
Summary: ftp/tnftp: Add mirrors and switch to DISTVERSION
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-09 22:51 UTC by Daniel Engberg
Modified: 2023-04-10 09:33 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (eduardo)


Attachments
Patch for tnftp (584 bytes, patch)
2023-04-09 22:51 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-04-09 22:51:39 UTC
Created attachment 241390 [details]
Patch for tnftp

- Switch to DISTVERSION as suggested by Porters Handbook
- Make use of NetBSD's CDN and add a few additional mirrors
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-04-10 08:00:26 UTC
(In reply to Daniel Engberg from comment #0)

> Switch to DISTVERSION as suggested by Porters Handbook

Reading handbook again, it seams that we should use PORTVERSION in specific cases like when it contains letters or for compability issues.
OK

> Make use of NetBSD's CDN and add a few additional mirrors

Nice to have CDN here and switch from ftp:// to http:// in some links.
OK

While we are here, do you have a suggestion for WWW:?

From README:

WHAT IS TNFTP?
--------------

`tnftp' is a `port' of the NetBSD FTP client to other systems.
See http://www.NetBSD.org/ for more details about NetBSD.

So, I'm thinking adding WWW: https://www.netbsd.org/

Any thoughts?

Cheers
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-04-10 08:25:19 UTC
(In reply to Nuno Teixeira from comment #1)
There's a table in Porters Handbook that covers most scenarios, search for "Table 2. Package Naming Examples".

As for WWW most other distros seems to use https://ftp.netbsd.org/pub/NetBSD/misc/tnftp/

Best regards,
Daniel
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-04-10 09:32:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7d6dc94b6f986651c9fcfe6721b02ef5e2e988d2

commit 7d6dc94b6f986651c9fcfe6721b02ef5e2e988d2
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-04-10 09:29:08 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-04-10 09:32:11 +0000

    ftp/tnftp: Add mirrors and switch to DISTVERSION

    - Switch to DISTVERSION as suggested by Porters Handbook
    - Make use of NetBSD's CDN and add a few additional mirrors

    while here:
    - Add WWW url

    PR:             270732

 ftp/tnftp/Makefile | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2023-04-10 09:33:35 UTC
Committed, thanks!