Bug 270779 - misc/heyu2: Fix for gcc10
Summary: misc/heyu2: Fix for gcc10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL: https://www.freshports.org/misc/heyu2/
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-12 05:34 UTC by mstowe
Modified: 2023-05-29 23:30 UTC (History)
3 users (show)

See Also:


Attachments
Diff for three patch files and Makefile (2.79 KB, patch)
2023-04-12 05:34 UTC, mstowe
no flags Details | Diff
Port with Github as source (1.17 KB, patch)
2023-04-16 05:26 UTC, mstowe
no flags Details | Diff
Revision to make portlint happier (630 bytes, patch)
2023-04-23 20:45 UTC, mstowe
no flags Details | Diff
Updated patch generated by git (1.52 KB, patch)
2023-05-28 23:46 UTC, mstowe
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mstowe 2023-04-12 05:34:10 UTC
Created attachment 241427 [details]
Diff for three patch files and Makefile

Updated Makefile, added patches to files:  patch-relay_aux, patch-tty, patch-tty_aux
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-04-12 10:52:38 UTC
Hi,

It seems like upstream has moved to https://github.com/HeyuX10Automation/heyu
Could you try to update the port to latest version which or possibly latest commit so it might build on recent versions of either GCC or perferably Clang?

Best regards,
Daniel
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-04-12 10:59:12 UTC
*sigh* Use the correct layout for summary
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2023-04-12 17:03:28 UTC
Side note: is the maintainer email address correct?
Comment 4 mstowe 2023-04-12 17:16:18 UTC
Maintainer address is correct as updated

> *sigh* Use the correct layout for summary

Sorry, noted

> It seems like upstream has moved to https://github.com/HeyuX10Automation/heyu

Well, sort of.  The more recent release candidates are on the original site, and the branches don't seem to have been reconciled.  The most recent changes were made were to fix compatibility with GCC10 were made to an older branch and therefore it seemed saner to rebuild the patches for the latest stable version.  The release candidate has remained a release candidate for more than a decade, but assuming it's ever released, this seems the right timing to resolve the branches.

> Could you try to update the port to latest version which or possibly latest commit so it might build on recent versions of either GCC or perferably Clang?

It is the latest version, as far as I can tell.  I haven't heard from the base maintainer in years, so I'm not optimistic that there are any plans to bring it up to date with newer compilers aside from the minimum.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2023-04-12 20:15:16 UTC
(In reply to mstowe from comment #4)
That was for myself doing multiple edits

The download link on the original site even points to GitHub so it seems to make sense updating the port to 2.10.3 it is labeled as release?

There's a section in Porters Handbook about how to use the framework with GitHub hosted projects which can be found here:
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
Comment 6 mstowe 2023-04-16 05:26:28 UTC
Created attachment 241525 [details]
Port with Github as source
Comment 7 mstowe 2023-04-22 16:11:51 UTC
... is anything else needed?
Comment 8 Graham Perrin freebsd_committer freebsd_triage 2023-04-23 06:36:01 UTC
(In reply to mstowe from comment #7)

Is one of the two attachments obsolete? If so, please mark it as such.
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2023-04-23 15:03:53 UTC
Please follow the example I linked to (portlint -C will also complain) and you don't need to set PORTREVISION when reset.

I'll give it a go once my boxes are free
Comment 10 mstowe 2023-04-23 20:45:14 UTC
Created attachment 241687 [details]
Revision to make portlint happier
Comment 11 mstowe 2023-05-14 20:03:24 UTC
Is there anything left to do here?
Comment 12 Robert Clausecker freebsd_committer freebsd_triage 2023-05-22 13:00:54 UTC
(In reply to mstowe from comment #11)

Hi mstowe,

Unfortunately your patch doesn't apply.  You also did not ship an update for distinfo, which is likely required for the port to build.

The easiest way to prepare a patch is to use git for the ports tree.  Clone the git repository, do your changes, commit them, and then use git-format-patch to create a ready-to-apply patch.

I'll try to get your changes committed once you submit a patch that applies.
Comment 13 Robert Clausecker freebsd_committer freebsd_triage 2023-05-22 13:01:28 UTC
And the reason your patch doesn't apply is that somehow, all tabs were converted to spaces.  Try to avoid that!
Comment 14 mstowe 2023-05-28 23:46:14 UTC
Created attachment 242470 [details]
Updated patch generated by git
Comment 15 Robert Clausecker freebsd_committer freebsd_triage 2023-05-29 00:53:36 UTC
Will commit with small changes with my next batch.
Comment 16 commit-hook freebsd_committer freebsd_triage 2023-05-29 23:27:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=de23ac1b35d0d2e0ec069d6eb3f01c59f268d3e1

commit de23ac1b35d0d2e0ec069d6eb3f01c59f268d3e1
Author:     Michael Stowe <mstowe@baddomain.com>
AuthorDate: 2023-05-28 23:37:52 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-29 23:25:27 +0000

    misc/heyu2: Update to 2.10.3, solves issue with gcc

    Changelog: https://github.com/HeyuX10Automation/heyu/releases/tag/v2.10.3

    PR:             270779

 misc/heyu2/Makefile | 17 ++++++++++-------
 misc/heyu2/distinfo |  5 +++--
 2 files changed, 13 insertions(+), 9 deletions(-)
Comment 17 Robert Clausecker freebsd_committer freebsd_triage 2023-05-29 23:30:38 UTC
Thank you for your contribution.