Created attachment 241464 [details] www/dokuwiki patch Update www/dokuwiki to 2023-04-04. Add options for some additional PHP module requirements that other sites may need (I do!).
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=29b993206cc08d3804711bc72b4109c1963f85e9 commit 29b993206cc08d3804711bc72b4109c1963f85e9 Author: Mike Fisher <mfisher911@gmail.com> AuthorDate: 2023-04-14 08:21:27 +0000 Commit: Xin LI <delphij@FreeBSD.org> CommitDate: 2023-04-14 08:21:28 +0000 www/dokuwiki: upgrade to 2023-04-04. Make the port depend on several commonly used PHP modules while there. PR: 270826 www/dokuwiki/Makefile | 5 +-- www/dokuwiki/distinfo | 6 +-- www/dokuwiki/pkg-plist | 100 +++++++++++++++++++++++++++++++++++++++++++------ 3 files changed, 94 insertions(+), 17 deletions(-)
(In reply to Mike Fisher from comment #0) Thanks! I think we should just depend on these modules, so I made the dependency permanent (along with some other extensions used by commonly used plugins).
(In reply to Xin LI from comment #2) Hi there, What was the rationale for making the module requirements permanent? Dokuwiki itself does not depend on either ldap nor mysql for instance (last time I checked). It actually prides itself on being minimalist with regards to requirements. If we were to add fixed dependencies for all sorts of packages (sqlite for instance) that some of the popular plugins (such as tags) need, we'd have to depend on lots more php modules. That cannot be right. If someone needs a plugin for dokuwiki that needs mysql or ldap they should be able to manually install the required php modules. It's not like the dokuwiki documentation does not mention such requirements for the plugins that have them? Please reconsider doing it this way. Upgrading dokuwiki to the latest version meant that I have now 6 additional packages installed that I have absolutely no use for: cyrus-sasl openldap26-client php80-ctype php80-ldap php80-pdo_mysql php80-simplexml (unless any of them actually *are* a hard requirement for dokuwiki itself, of course). Thanks, Martin
A commit in branch 2023Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e8d080c1d9c9073f204d0b94a221fc6a33aaaeb9 commit e8d080c1d9c9073f204d0b94a221fc6a33aaaeb9 Author: Mike Fisher <mfisher911@gmail.com> AuthorDate: 2023-04-14 08:21:27 +0000 Commit: Xin LI <delphij@FreeBSD.org> CommitDate: 2023-05-17 05:36:37 +0000 www/dokuwiki: upgrade to 2023-04-04. Make the port depend on several commonly used PHP modules while there. PR: 270826 (cherry picked from commit 29b993206cc08d3804711bc72b4109c1963f85e9) www/dokuwiki/Makefile | 5 +-- www/dokuwiki/distinfo | 6 +-- www/dokuwiki/pkg-plist | 100 +++++++++++++++++++++++++++++++++++++++++++------ 3 files changed, 94 insertions(+), 17 deletions(-)