Bug 271003 - sysutils/arc_summary: Error in sys.excepthook: … KeyError: 'arc_meta_limit'
Summary: sysutils/arc_summary: Error in sys.excepthook: … KeyError: 'arc_meta_limit'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-22 16:55 UTC by Graham Perrin
Modified: 2023-09-19 19:12 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jrm)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2023-04-22 16:55:22 UTC
root@mowa219-gjp4-8570p-freebsd:~ # arc_summary

------------------------------------------------------------------------
ZFS Subsystem Report                            Sat Apr 22 17:39:13 2023
FreeBSD 14.0-CURRENT                                       zpl version 5
Machine: mowa219-gjp4-8570p-freebsd (amd64)             spa version 5000

ARC status:                                                      HEALTHY
        Memory throttle count:                                         0

Error in sys.excepthook:
Traceback (most recent call last):
  File "/usr/local/bin/arc_summary", line 978, in <module>
    main()
  File "/usr/local/bin/arc_summary", line 972, in main
    section_calls[section](kstats)
  File "/usr/local/bin/arc_summary", line 563, in section_arc
    meta_limit = arc_stats['arc_meta_limit']
KeyError: 'arc_meta_limit'

Original exception was:
Traceback (most recent call last):
  File "/usr/local/bin/arc_summary", line 978, in <module>
    main()
  File "/usr/local/bin/arc_summary", line 972, in main
    section_calls[section](kstats)
  File "/usr/local/bin/arc_summary", line 563, in section_arc
    meta_limit = arc_stats['arc_meta_limit']
KeyError: 'arc_meta_limit'
root@mowa219-gjp4-8570p-freebsd:~ # uname -aKU
FreeBSD mowa219-gjp4-8570p-freebsd 14.0-CURRENT FreeBSD 14.0-CURRENT #38 main-n262032-5e2e3615d91f: Fri Apr  7 18:54:28 BST 2023     grahamperrin@mowa219-gjp4-8570p-freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG amd64 1400085 1400085
root@mowa219-gjp4-8570p-freebsd:~ #
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2023-04-22 17:22:02 UTC
Not reproducible on 13.2-RELEASE. 

I assume that the 14.0-CURRENT case is not only me …
Comment 2 Joshua Kinard 2023-09-18 17:13:11 UTC
(In reply to Graham Perrin from comment #1)

Dug into this while trying 14.0-BETA2 out on a spare machine.  It appears that the ZFS ARC metadata handling was re-written as part of OpenZFS pull request #14359:
https://github.com/openzfs/zfs/pull/14359

As a result, many of the metadata tunables are gone, replaced by a single new, "opaque" tunable called "vfs.zfs.arc.meta_balance", default '500'.  Not a lot of guidance on how this number applies, so I just removed the older tunable from sysctl.conf and will assume the new tunable's default is reasonable.

The older tunable is still mentioned in the Handbook, Chapter 22.6.1.  I assume that'll need to be tagged for future removal once 14.0-RELEASE is out.
Comment 3 Graham Perrin 2023-09-18 18:19:55 UTC
Thanks, 

(In reply to Joshua Kinard from comment #2)

> Handbook

Cross-reference: bug 261212 comment 19.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-09-19 19:10:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d3d5bb9cbd9703f17bf9664174efd790e09d7f79

commit d3d5bb9cbd9703f17bf9664174efd790e09d7f79
Author:     Joseph Mingrone <jrm@FreeBSD.org>
AuthorDate: 2023-09-19 19:01:44 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2023-09-19 19:01:44 +0000

    sysutils/arc_summary: Update to 2023-06-09 snapshot

    PR:             271003
    Sponsored by:   The FreeBSD Foundation

 sysutils/arc_summary/Makefile | 4 ++--
 sysutils/arc_summary/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 5 Joseph Mingrone freebsd_committer freebsd_triage 2023-09-19 19:12:06 UTC
Thanks for reporting.  The commit above should fix the problem.  Please re-open if that's not the case.