Bug 271077 - net-mgmt/netmagis-common: update to 2.3.6 and fix BROKEN
Summary: net-mgmt/netmagis-common: update to 2.3.6 and fix BROKEN
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-26 10:17 UTC by geoffroy desvernay
Modified: 2023-05-06 09:04 UTC (History)
2 users (show)

See Also:
pdagog: maintainer-feedback+


Attachments
git patch for net-mgmt/netmagis-* (7.15 KB, patch)
2023-04-26 10:17 UTC, geoffroy desvernay
pdagog: maintainer-approval+
Details | Diff
git patch for net-mgmt/netmagis-* (7.66 KB, patch)
2023-05-05 10:16 UTC, geoffroy desvernay
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description geoffroy desvernay 2023-04-26 10:17:15 UTC
Created attachment 241756 [details]
git patch for net-mgmt/netmagis-*

This patch updates netmagis-* to 2.3.6, and correct BROKEN state for netmagis-www and netmagis-topo

Same patch (to un-break) has been proposed upstream: https://gitlab.com/netmagis/netmagis/-/merge_requests/183

Changes (from https://gitlab.com/netmagis/netmagis/-/blob/master/CHANGES):
Version 2.3.6 - 2018/07/26
    - bug fix (issue #184): internal error when searching for any FQDN
    - feature: search page now includes a minimal help
Version 2.3.5 - 2018/05/02
    - infrastructure change: add the devtools/utils/mkrel script and
	modify RELENG accordingly
    - bug fix (issue #175): a mail role cannot be empty
    - bug fix (issue #163): invalid url for sort link in multiple host add
    - bug fix (issue #168): work-around for Tcllib 1.18 (ldap.tcl 1.8)
    - bug fix (issue #182): CAS sign-out from another application
    - bug fix (issue #153): accept application/xml for jasig 4.1 CAS server
    - bug fix (pull request #170): typo on mail attribute mapping for LDAP
    - feature (issue #177): add network name on host address in search results
    - feature (pull request #179 + issue #169) : wildcard in search
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-05-03 18:50:03 UTC
Comment on attachment 241756 [details]
git patch for net-mgmt/netmagis-*

Requesting maintainer feedback.
Comment 2 geoffroy desvernay 2023-05-05 07:41:44 UTC
Thank you Pierre :)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-05-05 09:43:48 UTC
Build fails with plist issues:

===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/netmagis/pkgtcl/ldap-bug-fix.192
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/net-mgmt/netmagis-common

Please check and resubmit.
Comment 4 geoffroy desvernay 2023-05-05 10:16:33 UTC
Created attachment 241992 [details]
git patch for net-mgmt/netmagis-*

Sorry, I missed this one…

port test and poudriere tested all three ports (not only netmagis-topo and netmagis-www :/ )
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-05-05 11:50:29 UTC
If you tested with poudriere-bulk(1), make sure to pass -t so extra tests are run.

Testing your new patch set...
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-05-06 09:03:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=87e62e5401b8b612ed62add60fab0e1d7d45e24a

commit 87e62e5401b8b612ed62add60fab0e1d7d45e24a
Author:     Geoffroy Desvernay <dgeo@centrale-marseille.fr>
AuthorDate: 2023-05-05 10:13:49 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-06 09:01:19 +0000

    net-mgmt/netmagis-*: update to 2.3.6 and unbreak

     - fix ld error duplicate symbol mobjlist

    Changelog: https://gitlab.com/netmagis/netmagis/-/blob/master/CHANGES

    PR:             271077
    Approved by:    pdagog@gmail.com (maintainer)

 net-mgmt/netmagis-common/Makefile                             |  4 ++--
 net-mgmt/netmagis-common/distinfo                             |  6 +++---
 .../netmagis-common/files/patch-topo_src_dumpgraph.c (new)    | 11 +++++++++++
 .../netmagis-common/files/patch-topo_src_extractcoll.c (new)  | 11 +++++++++++
 .../netmagis-common/files/patch-topo_src_extracteq.c (new)    | 11 +++++++++++
 .../netmagis-common/files/patch-topo_src_extractl1.c (new)    | 11 +++++++++++
 .../netmagis-common/files/patch-topo_src_extractl2.c (new)    | 11 +++++++++++
 .../netmagis-common/files/patch-topo_src_extractl3.c (new)    | 11 +++++++++++
 net-mgmt/netmagis-common/pkg-plist                            |  1 +
 net-mgmt/netmagis-topo/Makefile                               |  3 ---
 net-mgmt/netmagis-www/Makefile                                |  3 ---
 11 files changed, 72 insertions(+), 11 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-05-06 09:04:07 UTC
Thank you for your contribution.