Bug 271088 - devel/cdialog: Update to 1.3-20230209
Summary: devel/cdialog: Update to 1.3-20230209
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://invisible-island.net/dialog/C...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-27 00:52 UTC by takefu
Modified: 2023-05-10 06:51 UTC (History)
4 users (show)

See Also:
jcpierri: maintainer-feedback+


Attachments
cdialog-1.3.20230209,2.patch (908 bytes, patch)
2023-04-27 00:52 UTC, takefu
takefu: maintainer-approval? (jcpierri)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2023-04-27 00:52:54 UTC
Created attachment 241780 [details]
cdialog-1.3.20230209,2.patch

Upstream update.
https://invisible-island.net/dialog/CHANGES

2023/02/09
	+ install ".pc" files in the test-packages.
	+ add pkg-config ".pc" file, for use with the development library.

2023/02/07
	+ change shared-library configuration in test-packages to use the
	  ABI version in the library filename to match its SONAME.
	+ add sample scripts to test-packages, using new makefile rule
	  "install-examples".
	+ corrected cdialog*.install helper scripts in test-package for Debian
	+ change ftp URLs in test-packages to https
	+ updated configure script, e.g., for compiler-warning fixes.
	+ updated fur.po, zh_TW.po from
		http://translationproject.org/latest/dialog/
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-04-27 21:14:31 UTC
Please set the "maintainer-approval" flag on your patches if you wish for them to be committed.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-04-29 18:16:35 UTC
Robert, the OP is not the maintainer.

^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.


Thanks!
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-04-29 18:51:17 UTC
(In reply to Fernando Apesteguía from comment #2)

Hence "set" and not "set to '+'".
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-04-30 12:09:05 UTC
There is a weird error in poudriere that I haven't seen before. It happens in 12.4{amd64,i386}:

=>> Checking for filesystem violations... done
=>> Error: Filesystem touched during build:
var/run/ld-elf.so.hints: 
        size (199, 129)
build of devel/cdialog | cdialog-1.3.20230209,2 ended at Sat Apr 29 23:50:52 CEST 2023
build time: 00:00:20
!!! build failure encountered !!!

Takefu, can you confirm this?
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2023-05-02 09:20:19 UTC
ping!
Comment 6 Josmar Calin De Pierri 2023-05-02 11:10:21 UTC
(In reply to Fernando Apesteguía from comment #4)

Fernando, I don't use poudriere so I can't help on this, however, I applied the patch, compiled and tested without issues on 13.2 and 13.1, but I don't have any 12.4 around here to test on it, yet.
Comment 7 Matthias Andree freebsd_committer freebsd_triage 2023-05-05 23:00:41 UTC
(In reply to Fernando Apesteguía from comment #4)

Fernando, I haven't looked too deep, but I can reproduce this finding.
It would seem that something - possibly a package that gets installed on 12.4 - calls ldconfig while the 12.4 build is going on and adds two directories to the search path.

I can reproduce your issue, and the content of said file is:
% cat -t /var/run/ld-elf.so.hints
Ehnt^A^@^@^@M-^@^@^@^@G^@^@^@^@^@^@^@F^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@/lib:/usr/lib:/usr/lib/compat:/usr/local/lib:/usr/local/lib/compat/pkg^@

This, by contrast, is the default /var/run/ld-elf.so.hints, if you only launch the jail in poudriere and then run jexec <JID> csh and in csh 

Ehnt^A^@^@^@M-^@^@^@^@^^^@^@^@^@^@^@^@^]^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@/lib:/usr/lib:/usr/lib/compat^@

So something added /usr/local/lib:/usr/local/lib/compat/pkg to your linker path on 12.4 but not on 13.2. From the diff of my build logs I can't tell what requisite package might be causing it.
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2023-05-07 16:33:31 UTC
(In reply to Matthias Andree from comment #7)
Then it seems it is pkg itself the one adding that, right?
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-05-10 06:50:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=76b6cd9452953142332dcde38ba07e9946798a61

commit 76b6cd9452953142332dcde38ba07e9946798a61
Author:     takefu <takefu@airport.fm>
AuthorDate: 2023-04-29 18:12:17 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-05-10 06:45:08 +0000

    devel/cdialog: Update to 1.3-20230209

    ChangeLog: https://invisible-island.net/dialog/CHANGES

    2023/02/09
     * install ".pc" files in the test-packages.
     * add pkg-config ".pc" file, for use with the development library.

    2023/02/07
     * change shared-library configuration in test-packages to use the
      ABI version in the library filename to match its SONAME.
     * add sample scripts to test-packages, using new makefile rule
      "install-examples".
     * corrected cdialog*.install helper scripts in test-package for Debian
     * change ftp URLs in test-packages to https
     * updated configure script, e.g., for compiler-warning fixes.
     * updated fur.po, zh_TW.po from http://translationproject.org/latest/dialog/

    PR:             271088
    Reported by:    takefu@airport.fm
    Approved by:    jcpierri@gmail.com (maintainer, timeout > 2 weeks)

 devel/cdialog/Makefile | 2 +-
 devel/cdialog/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 10 Fernando Apesteguía freebsd_committer freebsd_triage 2023-05-10 06:51:12 UTC
I committed this because nobody answer in the mail list. I'm also using poudriere-devel so this might be a glitch with it. Please, contact me should you receive any pkg-fallout messages.

Thanks!