Bug 271153 - graphics/pywal: Add BACKEND group, Add WALLPAPER group, Add PYTHON2 option, Use ImageMagick as an optional dependency
Summary: graphics/pywal: Add BACKEND group, Add WALLPAPER group, Add PYTHON2 option, ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on: 266117 266118 266119 266120
Blocks:
  Show dependency tree / graph
 
Reported: 2023-04-30 23:43 UTC by Jesús Daniel Colmenares Oviedo
Modified: 2023-05-18 08:25 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (fuz)

Attachments
pywal-3.3.0.patch (1.91 KB, patch)
2023-04-30 23:43 UTC, Jesús Daniel Colmenares Oviedo 		no flags Details | Diff
pywal-3.3.0.patch (1.80 KB, patch)
2023-05-01 09:31 UTC, Jesús Daniel Colmenares Oviedo 		no flags Details | Diff
pywal-3.3.0.patch (1.79 KB, patch)
2023-05-15 12:07 UTC, Jesús Daniel Colmenares Oviedo 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús Daniel Colmenares Oviedo 2023-04-30 23:43:55 UTC 
Created attachment 241889 [details]
pywal-3.3.0.patch

Description:

* Add BACKEND group
* Add WALLPAPER group
* Add PYTHON2 option
* Use ImageMagick as an optional dependency

QA:

* portlint: OK (looks fine.)
* testport: OK (poudriere: 13.1-RELEASE, amd64, IMAGEMAGICK PYTHON2 COLORTHIEF COLORZ HAISHOKU SCHEMER2 BGS FEH HABAK HSETROOT NITROGEN tested)
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2023-05-01 08:30:23 UTC 
Support for Python2 is being phased out (as Python2 itself is end-of-life since three years), no new requests to support it are being accepted.
Comment 2 Jesús Daniel Colmenares Oviedo 2023-05-01 09:31:10 UTC 
Created attachment 241901 [details]
pywal-3.3.0.patch

Description:

* Drop python2 support

QA:

* portlint: OK (looks fine.)
* testport: OK (poudriere: 13.1-RELEASE, amd64, IMAGEMAGICK COLORTHIEF COLORZ HAISHOKU SCHEMER2 BGS FEH HABAK HSETROOT NITROGEN tested)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-05-01 10:09:44 UTC 
Would you like to maintain this port?  I don't particularly care about it.
Comment 4 Jesús Daniel Colmenares Oviedo 2023-05-01 10:57:57 UTC 
(In reply to Robert Clausecker from comment #3)

Yes, I can take care of it. Shall I send you a patch but changing `MAINTAINER`?
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-05-01 11:06:27 UTC 
Will take care of this on commit.
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-05-01 11:22:24 UTC 
Too many problems with the new dependencies you added.  Will process this one once I can go ahead with the dependencies.
Comment 7 Jesús Daniel Colmenares Oviedo 2023-05-15 12:07:19 UTC 
Created attachment 242193 [details]
pywal-3.3.0.patch

Changes:

* Remove SCHEMER2
* Change MAINTAINER
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-05-18 08:21:17 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=87a631817cab9935fd0f5b69287355a6e945f780

commit 87a631817cab9935fd0f5b69287355a6e945f780
Author:     Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org>
AuthorDate: 2023-05-15 13:23:10 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-18 08:19:42 +0000

    graphics/pywal: add optional dependencies, handover

    Add optional dependencies for setting wallpapers and generating
    colour schemes.  Submitter becomes maintainer.

    Approved by:    fuz (maintainer)
    PR:             271153

 graphics/pywal/Makefile | 33 ++++++++++++++++++++++++++++++---
 1 file changed, 30 insertions(+), 3 deletions(-)
Comment 9 Robert Clausecker freebsd_committer freebsd_triage 2023-05-18 08:25:22 UTC 
Thank you for your submission.