Bug 271175 - */*: Treewide, move users of libebur128 to ebur128
Summary: */*: Treewide, move users of libebur128 to ebur128
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-01 16:23 UTC by Daniel Engberg
Modified: 2023-05-02 21:56 UTC (History)
5 users (show)

See Also:


Attachments
Treewide patch (2.86 KB, patch)
2023-05-01 16:23 UTC, Daniel Engberg
acm: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-05-01 16:23:35 UTC
Created attachment 241910 [details]
Treewide patch

The rust port on my boxes performs about 15% or better on amd64 and aarch64 so I think it makes sense to make it the default variant.

Runtime tested with rsgain
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2023-05-01 18:08:23 UTC
Moin moin

It might make sense to do something similar as with librsvg2 to allow choosing rust/legacy via default-versions, if this is the first rust-port in this dependency chain.

mfg Tobias
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-05-01 18:41:06 UTC
Not sure if it's worth it?

audio/cantata pulls in X and friends like audio/mixxx
audio/libgroove is on life support upstream being optimistic (also depends on ffmpeg)
audio/mixxx and audio/mixxx22 pulls in X and friends so you're likely to use librsvg2
audio/pulseeffects is abandoned upstream, easyeffects is the new project name and targets pipewire
audio/rsgain depending on configuration of ffmpeg ebur128 might be the first user to pull in rust
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-05-02 21:55:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4cd440845e24202042e8b35a1c1db08a928b5946

commit 4cd440845e24202042e8b35a1c1db08a928b5946
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-05-02 21:35:15 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-05-02 21:35:19 +0000

    */*: Move consumers of libebur128 to ebur128

    ebur128 provides a noticable faster implementation on at least aarch64
    and amd64 so make it default treewide as they conflict. If there's a
    need further down the road we can add an option to choose between.

    PR:             271175
    Approved by:    acm, jhale (maintainers of some of the ports)
    Sponsored by:   Blinkinblox

 audio/cantata/Makefile      | 4 ++--
 audio/libgroove/Makefile    | 4 ++--
 audio/mixxx/Makefile        | 4 ++--
 audio/mixxx22/Makefile      | 4 ++--
 audio/pulseeffects/Makefile | 4 ++--
 audio/rsgain/Makefile       | 3 ++-
 6 files changed, 12 insertions(+), 11 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-05-02 21:56:33 UTC
Forgot to add, jhale acked via private email.