Bug 271225 - net/dpdk-20.11: Update DPDK 20.11 to latest point release
Summary: net/dpdk-20.11: Update DPDK 20.11 to latest point release
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-03 12:27 UTC by Bruce Richardson
Modified: 2023-05-06 09:05 UTC (History)
2 users (show)

See Also:


Attachments
patch for update (4.53 KB, patch)
2023-05-03 12:27 UTC, Bruce Richardson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruce Richardson 2023-05-03 12:27:33 UTC
Created attachment 241952 [details]
patch for update

DPDK 20.11.8 was released end of last month. Update the port to this version.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-05-03 18:48:08 UTC
Will commit with my next batch.

Do you have a changelog for this update?

As for the ONLY_FOR_ARCHS.  Are you certain the port doesn't work on other architectures?  The standard for setting this is if you know it won't work.  If you just haven't tested it, please leave this variable unset.  You can disable individual architectures with NOT_FOR_ARCHS and BROKEN_${ARCH} once they turn out to not work.  If everybody just submitted ports for the architectures the submitter tested, lesser used architectures would have no ports at all...

I've just tested on aarch64 for example and found that it doesn't build, but the issue looks like it would be easy to fix:

../lib/librte_eal/arm/rte_cpuflags.c:86:9: error: unknown type name 'Elf64_auxv_t'
typedef Elf64_auxv_t _Elfx_auxv_t;
        ^

(our ELF aux value code is slightly different from how Linux does it).
Comment 2 Bruce Richardson 2023-05-04 09:24:26 UTC
Unfortunately, no, there is no single changelog I have for this update, but the following links give some details of the updates since the previous .5 release:

.6 -> .7: http://inbox.dpdk.org/announce/20221213140809.3845954-1-luca.boccassi@gmail.com/T/#u

.5 -> .6: http://inbox.dpdk.org/announce/20220829150456.2223782-1-xuemingl@nvidia.com/T/#u

Currently enquiring as to whether there is an available similar announcement email listing patches applied from .7 to .8 releases.
Comment 3 Bruce Richardson 2023-05-04 09:27:14 UTC
In terms of the other architectures: If I remove the restriction on the single architecture, what would happen then? Would there be a set of bug reports generated for the failing architectures, or what would the usual process be for making - and more importantly testing - those failing arch's. I don't actually have any non-intel systems available to me right now, but I can probably request help from others in the DPDK community to fix up arm or PPC builds if I can point them at an easy-to-process set of issues encountered.
Comment 4 Bruce Richardson 2023-05-04 09:28:59 UTC
(In reply to Bruce Richardson from comment #2)

Updates from .7 -> .8: http://inbox.dpdk.org/announce/20230427184829.1368323-1-luca.boccassi@gmail.com/T/#u
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-05-04 11:26:10 UTC
(In reply to Bruce Richardson from comment #3)

The ports build cluster periodically builds all ports that need to be rebuilt.  Whenever a build fails, an email is sent to the maintainer.  The logs are also available to the general public on the Ports Fallout site.  For example, for your port that would be:

    https://portsfallout.com/fallout?port=net%2Fdpdk-20.11%24

If you need help with ARM patching and testing, I may be able to assist you.  For PPC patching and testing, you may want to talk to pkubaj@FreeBSD.org, who does quality assurance for the ports collection on POWER platforms.

I'll put your port onto my list of ports to check on ARM and report back with patches if the issues are easy enough to fix.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-05-06 09:03:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bb72fff7b61899dd0357d3b6e61a3549b44f0faf

commit bb72fff7b61899dd0357d3b6e61a3549b44f0faf
Author:     Bruce Richardson <bruce.richardson@intel.com>
AuthorDate: 2023-05-03 09:52:42 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-06 09:00:01 +0000

    net/dpdk-20.11: update to point release 20.11.8

    Update dpdk-20.11 port to the latest point release version.
    This update also includes cleanup for the makefile, as suggested
    by portclippy & portfmt.

    Changelog: http://inbox.dpdk.org/announce/20220829150456.2223782-1-xuemingl@nvidia.com
    Changelog: http://inbox.dpdk.org/announce/20221213140809.3845954-1-luca.boccassi@gmail.com
    Changelog: http://inbox.dpdk.org/announce/20230427184829.1368323-1-luca.boccassi@gmail.com

    PR:             271225

 net/dpdk-20.11/Makefile                            | 26 +++++++-------
 net/dpdk-20.11/distinfo                            |  6 ++--
 ...ib_librte__eal_freebsd_include_rte__os.h (gone) | 41 ----------------------
 3 files changed, 16 insertions(+), 57 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-05-06 09:05:12 UTC
Thank you for your contribution.