Created attachment 241971 [details] patch for crowdsec-blocklist-mirror 0.0.2 Update to new upstream version
Is it still required to pin a particular Go toolchain version? Unless there's a reason why only a specific Go toolchain can be used, Go ports should not restrict themselves like this.
(In reply to Robert Clausecker from comment #1) Thanks a lot for the review. We have five bouncers written in Go which import code from the main crowdsec repository, where we use features introduced in Go 1.20 Therefore, it made sense for me to transfer the dependency to the bouncers too. The Makefile will honor the variable BUILD_REQUIRE_GO_MINOR=20, it can be overridden if required but we have not tested the previous versions.
(In reply to marco from comment #2) Specifying a Go version is to ensure no newer Go toolchain will be selected. By default, the newest non-devel Go toolchain in the tree is used. I recommend removing the 1.20 unless you know that the code won't build with newer Go toolchains. I.e. you won't get a 1.19 toolchain if you don't specify which toolchain to use. If you prefer to leave it as is, I can however go ahead and commit your patch as is. For future updates, please set maintainer-approval to "+" to indicate that you approve of the patch. This speeds up processing.
Created attachment 242084 [details] patch for crowdsec-blocklist-mirror 0.0.2, without go:1.20
(In reply to Robert Clausecker from comment #3) Thanks, I understand better now! I updated the patch.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fce7ec1e71982958b8108489256b94658f917647 commit fce7ec1e71982958b8108489256b94658f917647 Author: Marco Mariani <marco@crowdsec.net> AuthorDate: 2023-05-04 14:33:19 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-05-11 23:23:23 +0000 security/crowdsec-blocklist-mirror: update to 0.0.2 Changelog: https://github.com/crowdsecurity/cs-blocklist-mirror/releases/tag/v0.0.2 PR: 271241 security/crowdsec-blocklist-mirror/Makefile | 7 +++---- security/crowdsec-blocklist-mirror/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 7 deletions(-)
Thank you for your contribution.