Created attachment 242159 [details] Patch for lang/squeak disabling the warning on incompatible pointer to integer conversion
did you submit this issue upstream?
(In reply to Mina Galić from comment #1) No, I haven't. I saw a bunch of similar recent commits to the ports tree and figured one more wouldn't hurt.
Created attachment 242177 [details] Update patch to build in my environment. Updated the patch because of following error in my environment. make: "/usr/home/mutoh/work/ports/lang/squeak/Makefile" line 67: Malformed conditional (${OPSYS} == FreeBSD && ${OSVERSION} >= 1400079) make: Fatal errors encountered -- cannot continue make: stopped in /usr/home/mutoh/work/ports/lang/squeak Upstream has already finished developing this version of the Squeak VM, and I don't think they will incorporate this patch.
Created attachment 242181 [details] Patch for lang/squeak disabling the warning on incompatible pointer to integer conversion It's better to include bsd.port.pre.mk and bsd.port.post.mk at the appropriate spots.
(In reply to Trond.Endrestol from comment #4) I try this patch work fine. So please commit it.
(In reply to takeshi.mutoh from comment #5) To avoid confusion, can you approve the patch you want to commit? (I think it is Trond's, but you approved your own instead).
Created attachment 242255 [details] Patch for lang/squeak disabling the warning on incompatible pointer to integer conversion Inspired by commit 9b178ffd7e2fd77fecb8c80d22f7c80bc9e93977, take 13.2-STABLE >= 1302505 into account.
Ping.
Comment on attachment 242177 [details] Update patch to build in my environment. The other patch takes 13.2-STABLE into consideration.
Last ping.
(In reply to Trond.Endrestol from comment #7) Is this ping for me (maintainer) at comment #10? I think there is no problem this patch. So please commit.
(In reply to takeshi.mutoh from comment #11) Again, there are *two patches* in this PR. One by you, one by Trond. Both are maintainer-approved. Please: mark as the one that you *DON'T WANT* to be committed as obsolete :-) From your last comment it is still not clear what patch you want to be committed.
Comment on attachment 242177 [details] Update patch to build in my environment. This patch don't care above 13.2-stable case. So this patch becomes obsolete.
(In reply to Fernando Apesteguía from comment #12) I'm sorry. I delete obsolete the patch (attachment 242181 [details]) and set maintainer-approved - at it. Please commit attachment 242255 [details].
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=89ea113f0776c599e0f7c490bcfba9d7101c3dc8 commit 89ea113f0776c599e0f7c490bcfba9d7101c3dc8 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2023-06-01 06:35:26 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-06-02 06:49:10 +0000 lang/squeak: unbreak build on current PR: 271406 Reported by: Trond.Endrestol@ximalas.info Approved by: takeshi.mutoh@gmail.com (maintainer) lang/squeak/Makefile | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)