Bug 271420 - devel/rubygem-i18n: can't modify frozen String: "Bytes"
Summary: devel/rubygem-i18n: can't modify frozen String: "Bytes"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Fechner
URL:
Keywords:
Depends on:
Blocks: 271356
  Show dependency treegraph
 
Reported: 2023-05-14 17:38 UTC by Matthias Fechner
Modified: 2023-06-06 04:00 UTC (History)
2 users (show)

See Also:
sunpoet: maintainer-feedback+


Attachments
Fix frozen string (1.65 KB, patch)
2023-06-02 06:18 UTC, Matthias Fechner
mfechner: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Fechner freebsd_committer freebsd_triage 2023-05-14 17:38:01 UTC
The update breaks some views in the gitlab port.
The problem could be related to this issue:
https://github.com/ruby-i18n/i18n/issues/648

There was already a PR merged that maybe fixes the problem with gitlab, I will try to verify if applying the patch fixes the problem:
https://github.com/ruby-i18n/i18n/pull/587

The PR was already merged upstream, maybe we need to add a patch till upstream release a new version that includes this patch.
Comment 1 Matthias Fechner freebsd_committer freebsd_triage 2023-05-15 19:39:50 UTC
I downgrade to version 1.12.0 fixed the problem, so it is confirmed that version 1.13.0 has implemented a bug or did break the ABI
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-05-27 22:53:44 UTC
I'm afraid I'm a bit confused. What is the patch you'd like me to commit?

(In reply to Matthias Fechner from comment #0)

https://github.com/ruby-i18n/i18n/pull/587 was merged as https://github.com/ruby-i18n/i18n/commit/2ab9b377744258305d57860fcb08cd81d9767ee4 which is in i18n since 1.9.0.
Comment 3 Matthias Fechner freebsd_committer freebsd_triage 2023-05-28 07:54:46 UTC
(In reply to Po-Chuan Hsieh from comment #2)
The only way I could currently fix the problem was downgrading i18n to 1.12.0.

To check if the problem is really fixed is very time consuming, as gitlab seems to produces files while using the UI that triggers the problem not immediately.
So just install a new version is not enough to verify if the problem is fixed or not.
Comment 4 Geoffrey Mainland 2023-06-01 16:52:11 UTC
I think this is the relevant issue:
https://github.com/ruby-i18n/i18n/issues/658
Comment 5 Matthias Fechner freebsd_committer freebsd_triage 2023-06-02 05:30:23 UTC
Thanks for the tip, I currently test the patch that was suggested and will provide a diff if it works.
Comment 6 Matthias Fechner freebsd_committer freebsd_triage 2023-06-02 06:18:55 UTC
Created attachment 242551 [details]
Fix frozen string

I tested it with this patch and could not reproduce the error anymore.

Is it ok, if I commit this patch?
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-06-05 19:32:14 UTC
LGTM. Please rename the patch to patch-bug-271420. And PORTREVISION should appear between PORTVERSION and PORTEPOCH. Thanks.
Comment 8 Matthias Fechner freebsd_committer freebsd_triage 2023-06-05 20:19:29 UTC
(In reply to Po-Chuan Hsieh from comment #7)
Thanks, I will do another testbuild against current main branch and will push the commit after it was successful.
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-06-06 03:34:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d9c7bd925458d6d51ddbdafe03cf1e5a1a422c16

commit d9c7bd925458d6d51ddbdafe03cf1e5a1a422c16
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2023-06-02 06:10:14 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2023-06-06 03:32:56 +0000

    devel/rubygem-i18n: fix frozen string

    With version v1.13.0 code was changed that returns a frozen string.
    This breaks e.g. gitlab-ce on some pages.
    Geoffrey Mainland (mainland@apeiron.net) pointed to the issue
    logged upstream:
    https://github.com/ruby-i18n/i18n/issues/658

    PR:             271420
    PR:             271356
    Approved by:    sunpoet (maintainer)

 devel/rubygem-i18n/Makefile                     |  1 +
 devel/rubygem-i18n/files/patch-bug-271420 (new) | 11 +++++++++++
 2 files changed, 12 insertions(+)