Created attachment 242293 [details] textproc/py-sphinxcontrib-svg2pdfconverter: use USES=gnome to depend on librsvg2 This port currently selects which rsvg2 dependency to use based on a port option. This is quite suboptimal as most (but not all) architectures use the rust variant by default, but this port uses the old C variant. Thus there are package conflicts when you try to install this port and and various GUI ports at the same time. To fix this, the port should not supply an option but rather depend on rsvg by using USES= gnome USE_GNOME= librsvg2 This will pick the correct librsvg dependency depending on which one the user selected as his/her default and on what is installed. Attached patch implements this change.
Wow this is a great improvement. I am all in favour of merging provided build testing has been done? Thanks.
Comment on attachment 242293 [details] textproc/py-sphinxcontrib-svg2pdfconverter: use USES=gnome to depend on librsvg2 I always perform build tests before commit and I've done a manual build test and ran all the usual QA tools before submitting this patch to you. Will take this as approval from your side. How's the test with your mame patch going?
Will commit with my next batch.
(In reply to Robert Clausecker from comment #2) All good from my side, thanks. mame is a worth adversary.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bce94ecce5f905028f4f922b80bb32e5e1563dda commit bce94ecce5f905028f4f922b80bb32e5e1563dda Author: Robert Clausecker <fuz@FreeBSD.org> AuthorDate: 2023-05-20 11:44:04 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-05-21 17:25:41 +0000 textproc/py-sphinxcontrib-svg2pdfconverter: depend on correct librsvg2 automatically Instead of providing a port option, have USES=gnome figure out the right librsvg2 to depend on. This avoids conflicts when installing mame with other ports that depend on librsvg2{,-rust}. Approved by: agh@riseup.net (maintainer) MFH: 2023Q2 PR: 271530 textproc/py-sphinxcontrib-svg2pdfconverter/Makefile | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-)
A commit in branch 2023Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=dc299b36fdc2faedaab1b411afa5e6cae7b68619 commit dc299b36fdc2faedaab1b411afa5e6cae7b68619 Author: Robert Clausecker <fuz@FreeBSD.org> AuthorDate: 2023-05-20 11:44:04 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-05-21 17:27:20 +0000 textproc/py-sphinxcontrib-svg2pdfconverter: depend on correct librsvg2 automatically Instead of providing a port option, have USES=gnome figure out the right librsvg2 to depend on. This avoids conflicts when installing mame with other ports that depend on librsvg2{,-rust}. Approved by: agh@riseup.net (maintainer) MFH: 2023Q2 PR: 271530 (cherry picked from commit bce94ecce5f905028f4f922b80bb32e5e1563dda) textproc/py-sphinxcontrib-svg2pdfconverter/Makefile | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-)
Thank you for your contribution.