Created attachment 242403 [details] Patch updating to 2.24.1 - update to version 2.24.1
You have removed tex from USES but still have USE_TEX=latex in there. Is this correct? For the post-patch REINPLACE_CMD, check if you can replace the static REINPLACE_CMD uses with patch files as per policy. REINPLACE_CMD should only be used for dynamic replacements, i.e. those where the substitution is dependent on a make variable or such.
Created attachment 242412 [details] updated patch - removed overlooked USE_TEX - turned post-patch REINPLACE_CMD into regular patch
(In reply to Robert Clausecker from comment #1) The USE_TEX line was an oversight; thanks for spotting this. The REINPLACE_CMD, however, was already present when I adopted the port (I think...), and I just kept it there over the years. But as it is indeed a fully static change, and I'm not terribly attached to that line, it is now gone as well and replaced by a patch.
Thank you for the quick update. I believe policy had changed a while ago regarding REINPLACE_CMD and instead of bulk-updating all ports, we're gradually changing ports over whenever there's an update. Will commit your various submitted patches with my next batch. There were some difficulties applying your previous patch, but I think I got it.
(In reply to Robert Clausecker from comment #4) That does seem plausible, and I think that approach to implementing that new policy is quite sensible. On that note, I did that change to the patch for lilypond-devel as well. Thanks for moving this forward.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=41234ceb6e1fa23aa50b5b680bf1e9d7333c8bcb commit 41234ceb6e1fa23aa50b5b680bf1e9d7333c8bcb Author: Martin Neubauer <m.ne@gmx.net> AuthorDate: 2023-05-26 10:16:31 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-05-29 23:24:05 +0000 print/lilypond: update to 2.24.1 Changelog: http://lilypond.org/news.html#LilyPond-2_002e24_002e1-released_0021-February-12_002c-2023 PR: 271637 print/lilypond/Makefile | 37 ++- print/lilypond/distinfo | 6 +- .../lilypond/files/patch-Documentation_GNUmakefile | 16 +- print/lilypond/files/patch-config.make.in | 6 +- print/lilypond/files/patch-configure (gone) | 77 ------- .../patch-lily_include_includable-lexer.hh (new) | 11 + .../lilypond/files/patch-lily_midi-item.cc (gone) | 11 - ...info-vars.make => patch-make_texinfo-vars.make} | 8 +- print/lilypond/pkg-plist | 248 ++++++++++----------- 9 files changed, 161 insertions(+), 259 deletions(-)
Thank you for your contribution.