Bug 271663 - audio/musicpd Only local storage plugin is available
Summary: audio/musicpd Only local storage plugin is available
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-26 22:10 UTC by Ivan
Modified: 2023-05-27 08:53 UTC (History)
0 users

See Also:
riggs: maintainer-feedback+

Attachments
poudriere build log (589.95 KB, text/plain)
2023-05-26 22:10 UTC, Ivan 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan 2023-05-26 22:10:05 UTC 
Created attachment 242431 [details]
poudriere build log

I've compiled musicpd, however it looks like it contains only local storage plugin. 

Storage plugins:
 local

How can I enable curl support? It's turned on in port options.
Comment 1 Ivan 2023-05-26 22:35:07 UTC 
webdav MESON arg must be enabled to compile curl backend. webdav assumes CURL and EXPAT.

The easiest way is to add CURL_MESON_ENABLED=	curl webdav but better to add separate option.
Comment 2 Thomas Zander freebsd_committer freebsd_triage 2023-05-27 06:29:28 UTC 
Thanks for the report!

There's two different things at play here.
1) The ability to access web URLs via curl is enabled with the CURL option. Even without webdav it allows to stream single URLs with mpd, e.g. webradio.
2) Webdav is an optional plugin on top.

I'll enable webdav if curl is enabled, since it does not require additional dependencies.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-05-27 06:41:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ca5fd0c991d382e3bcce32dec80dc4c5e6547931

commit ca5fd0c991d382e3bcce32dec80dc4c5e6547931
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2023-05-27 06:30:59 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2023-05-27 06:41:37 +0000

    audio/musicpd: Enable the webdav storage plugin if curl is enabled

    Details:
    - With curl enabled, the webdav storage plugin can be enabled as well,
      allowing folks to access their collections via webdav.
    - No new dependencies are required to support this feature.

    PR:             271663
    Reported by:    bsd@abinet.ru
    MFH:            2023Q2

 audio/musicpd/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-05-27 08:48:04 UTC 
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3fcdf99b73193b4c12355520b0e8e4e54f73cafa

commit 3fcdf99b73193b4c12355520b0e8e4e54f73cafa
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2023-05-27 06:30:59 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2023-05-27 06:43:39 +0000

    audio/musicpd: Enable the webdav storage plugin if curl is enabled

    Details:
    - With curl enabled, the webdav storage plugin can be enabled as well,
      allowing folks to access their collections via webdav.
    - No new dependencies are required to support this feature.

    PR:             271663
    Reported by:    bsd@abinet.ru
    MFH:            2023Q2

    (cherry picked from commit ca5fd0c991d382e3bcce32dec80dc4c5e6547931)

 audio/musicpd/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Ivan 2023-05-27 08:53:17 UTC 
Thanks! The backend works.