Created attachment 242501 [details] net/miniupnpd: remove ipfw port option It is well-known that net/miniupnpd does not work with IPFW. However, the port options still allow building with IPFW support. In order to prevent unnecessary foot-shooting, let us eliminate this option outright and unconditionally use pf instead.
Will commit with my next batch. If the maintainer times out again, perhaps you might want to take over maintainership of this port.
If that's the case perhaps also submit a fix upstream? https://github.com/miniupnp/miniupnp
(In reply to Daniel Engberg from comment #2) See bug #232396. The ipfw support is meant for macOS, not FreeBSD. MacOS ipfw has a different API than FreeBSD, so it's unlikely that it was every meant to work here.
(In reply to Robert Clausecker from comment #1) I would be willing to take maintainership if necessary. We can also close bug #251822 alongside this one as if we are unconditionally configuring miniupnpd to use pf(4) on FreeBSD (which we absolutely should), there then can't be any firewall detection problem *smiles*
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=dcb400297a3bd5a5880c2abf0cead0dc53004ca3 commit dcb400297a3bd5a5880c2abf0cead0dc53004ca3 Author: R. Christian McDonald <rcm@rcm.sh> AuthorDate: 2023-05-30 19:03:18 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-06-26 23:30:28 +0000 net/miniupnpd: remove ipfw port option It is well-known that net/miniupnpd does not work with IPFW. However, the port options still allow building with IPFW support. In order to prevent unnecessary foot-shooting, let us eliminate this option outright and unconditionally use pf instead. PR: 271732 Approved by: squat@squat.no (maintainer timeout, two weeks) Sponsored by: Rubicon Communications, LLC ("Netgate") net/miniupnpd/Makefile | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)
Thank you for your contribution.