Bug 271887 - devel/py-dj41-graphene-django: Downgrade to 3.0.0
Summary: devel/py-dj41-graphene-django: Downgrade to 3.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-07 16:27 UTC by Kai Knoblich
Modified: 2023-06-12 11:09 UTC (History)
1 user (show)

See Also:
sunpoet: maintainer-feedback+


Attachments
py-dj41-graphene-django-downgrade-to-3.0.0-v1.patch (2.93 KB, patch)
2023-06-07 16:27 UTC, Kai Knoblich
kai: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2023-06-07 16:27:53 UTC
Created attachment 242663 [details]
py-dj41-graphene-django-downgrade-to-3.0.0-v1.patch

Hi Sunpoet,

attached is a patch that downgrades devel/py-dj41-graphene-django to 3.0.0 and sets the version requirements of net-mgmt/netbox and www/py-dj41-django-graphiql-debug-toolbar accordingly.

This is because there's a regression (Issue #12762) with NetBox 3.5.x in conjunction with graphene-django > 3.0.0, which was reported at the end of May.

With graphene-django > 3.0.0 a blank screen is produced when the GraphQL web API is called. Upstream won't fix the issue as they plan to replace graphene-django with an alternate GraphQL implementation.


Rationale for the downgrade with bump of PORTEPOCH:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- devel/py-dj41-graphene-django has net-mgmt/netbox and www/py-dj41-graphiql-debug-toolbar as only consumers at the moment.

- NetBox 3.6 (ETA: end of August 2023) will use Django 4.2, the next LTS release, which will then require a few py-dj42-* ports.

- Django 4.1 reaches its EoL at the End of 2023.


Would the downgrade of devel/py-dj41-graphene-django fine for you?

Another option would be to copy devel/py-dj41-graphene-django to devel/py-dj41-graphene-django300 (or similar).


QA:
~~~
- poudriere -> OK (12.4-RELEASE amd64, py38, py39, py310, py311)
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-06-12 05:51:08 UTC
I agree with you to downgrade it to 3.0.0.

And I suggest the following changes:
- Use PORTSCOUT=ignore:1
- Use dj41-graphene-django>=3.0.0,1<3.0.0_99,1 

Thanks.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-06-12 11:01:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eae23f2d14fad5318416c59814806b99c2165797

commit eae23f2d14fad5318416c59814806b99c2165797
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2023-06-12 10:58:42 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2023-06-12 10:58:42 +0000

    devel/py-dj41-graphene-django: Downgrade to 3.0.0

    * Since NetBox 3.5, there has been a regression with newer versions of
      py-graphene-django that produces a blank screen at the GraphQL API.

      Hence, upstream has pinned the version of py-graphene-django to 3.0.0
      with the release of NetBox 3.5.3 because an alternative implementation
      is planned for the GraphQL feature.

    * Add PORTSCOUT because upstream is very likely to switch to Django 4.2
      with the NetBox 3.6 release series (ETA: Mid of 2023Q3) and
      Django 4.1 will reach its EoL (= End-of-Life) at the end of 2023.

    * Adjust the version requirements of net-mgmt/netbox and
      www/py-dj41-graphiql-debug-toolbar accordingly.

    PR:             271887
    Reviewed by:    sunpoet (maintainer)
    Approved by:    sunpoet (maintainer)

 devel/py-dj41-graphene-django/Makefile             | 5 ++++-
 devel/py-dj41-graphene-django/distinfo             | 6 +++---
 net-mgmt/netbox/Makefile                           | 2 +-
 www/py-dj41-django-graphiql-debug-toolbar/Makefile | 2 +-
 4 files changed, 9 insertions(+), 6 deletions(-)
Comment 3 Kai Knoblich freebsd_committer freebsd_triage 2023-06-12 11:09:25 UTC
Comment on attachment 242663 [details]
py-dj41-graphene-django-downgrade-to-3.0.0-v1.patch

(In reply to Po-Chuan Hsieh from comment #1)

Committed, thanks for the approval and the pointers. The pinned version requirement and PORTSCOUT were adjusted accordingly.