Bug 272003 - devel/linux-sublime-merge: Permissions to /usr/local/share/sublime-merge/ssh-ask-keypass-sublime sub-optimal
Summary: devel/linux-sublime-merge: Permissions to /usr/local/share/sublime-merge/ssh-...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Eric Turgeon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-15 03:06 UTC by frostygoth
Modified: 2023-06-23 00:00 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ericbsd)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description frostygoth 2023-06-15 03:06:57 UTC 
Hello,

I installed linux-sublime-merge this morning and was able to activate it and get basic functionality out of it right out of the box. Thanks Eric!

However, when trying to pull from GitHub with Personal Access Tokens enforced I got the error below.

"/usr/local/share/sublime-merge/git-credential-sublime get: /usr/local/share/sublime-merge/git-credential-sublime: Permission denied
fatal: cannot exec '/usr/local/share/sublime-merge/ssh-askpass-sublime': Permission denied
fatal: could not read Username for 'https://github.com': terminal prompts disabled"

I checked the permissions of /usr/local/share/sublime-merge/ssh-askpass-sublime and confirmed they were... 
"-rw-r--r--  1 root  wheel      5216 Feb  6 15:44 ssh-askpass-sublime" 
so I didn't have permissions to execute the binary. 

Easy fix was to update the permissions to the following... 
"-rwxrwxr--  1 root  wheel      5216 Feb  6 15:44 ssh-askpass-sublime" 
No big deal, however that does keep some functionality of the program locked until the change is made. 

If this is a design decision due to a security concern, I totally respect that. However, I think changing the default permissions to include execution of at least the wheel group is a sane default and would improve the functionality of this software, making it that much easier to use FreeBSD!

Please let me know if you need additional information!



Basic OS and Package info...

uname -a : FreeBSD <computer_name> 13.1-RELEASE-p3 FreeBSD 13.1-RELEASE-p3 GENERIC amd64

pkg info linux-sublime-merge
linux-sublime-merge-2083
Name           : linux-sublime-merge
Version        : 2083
Installed on   : Wed Jun 14 06:10:48 2023 CDT
Origin         : devel/linux-sublime-merge
Architecture   : FreeBSD:13:amd64
Prefix         : /usr/local
Categories     : linux devel
Licenses       : SUBLIMEHQ
Maintainer     : ericbsd@FreeBSD.org
WWW            : https://www.sublimemerge.com/
Comment        : Cross-platform Git client, done the Sublime Text way
Annotations    :
	FreeBSD_version: 1301000
	repo_type      : binary
	repository     : FreeBSD
Comment 1 frostygoth 2023-06-15 03:27:18 UTC 
Now that I think about it, 0554 permissions should be fine on this since all I need to do is execute it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-06-22 23:58:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=22cf897462c866ba9d53750d98185876edff9e42

commit 22cf897462c866ba9d53750d98185876edff9e42
Author:     Eric Turgeon <ericbsd@FreeBSD.org>
AuthorDate: 2023-06-22 23:52:52 +0000
Commit:     Eric Turgeon <ericbsd@FreeBSD.org>
CommitDate: 2023-06-22 23:52:52 +0000

    devel/linux-sublime-merge: fix ssh-ask-keypass-sublime

    Also updated to 2085

    PR: 272003
    Reported by: frostygoth@hotmail.com

 devel/linux-sublime-merge/Makefile  |  2 +-
 devel/linux-sublime-merge/distinfo  | 10 +++++-----
 devel/linux-sublime-merge/pkg-plist |  8 +++-----
 3 files changed, 9 insertions(+), 11 deletions(-)
Comment 3 Eric Turgeon freebsd_committer freebsd_triage 2023-06-23 00:00:49 UTC 
(In reply to frostygoth from comment #0)
This should be fixed in my new commit.