Bug 272036 - net/syncthing: update to 1.23.6
Summary: net/syncthing: update to 1.23.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-17 10:04 UTC by Anton Saietskii
Modified: 2023-07-31 00:00 UTC (History)
3 users (show)

See Also:
dvl: maintainer-feedback+


Attachments
patch for update (874 bytes, patch)
2023-06-17 10:04 UTC, Anton Saietskii
no flags Details | Diff
updated patch: PORTREVISION reset (969 bytes, patch)
2023-06-18 13:06 UTC, Anton Saietskii
no flags Details | Diff
poudriere build log (24.02 KB, text/plain)
2023-06-18 13:28 UTC, Anton Saietskii
no flags Details
patch for update (950 bytes, patch)
2023-07-07 14:16 UTC, Anton Saietskii
vsasjason: maintainer-approval?
Details | Diff
poudriere build log (23.94 KB, text/plain)
2023-07-07 14:19 UTC, Anton Saietskii
no flags Details
screenshot with 1.23.6 running (48.34 KB, image/png)
2023-07-12 15:02 UTC, Anton Saietskii
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2023-06-17 10:04:56 UTC
Created attachment 242821 [details]
patch for update

1.23.5 has been released ~2 weeks ago despite not being listed on syncthing.net

While here, I would like to ask: perhaps net-p2p/ would be a better category rather than net/?
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-06-17 11:00:12 UTC
We also probably should track down why 1.20.3 don't work as upstream now uses it.

See https://github.com/syncthing/syncthing/issues/8799

The race switch also seems troublesome in general:
https://git.alpinelinux.org/aports/tree/community/syncthing/only-test-with-race-when-provided.patch
https://gitlab.archlinux.org/archlinux/packaging/packages/syncthing/-/blob/main/gcc-pie-segfaults-race.patch

With the patch I see:
2023/06/17 12:48:01 INFO: TCP listener (127.0.0.1:62565) starting
panic: test timed out after 2m0s
running tests:
        TestConnectionEstablishment (2m0s)
        TestConnectionEstablishment/tcp (2m0s)

Without:
"fatal error: checkptr: converted pointer straddles multiple allocations"
Comment 2 Anton Saietskii 2023-06-18 13:06:03 UTC
Created attachment 242865 [details]
updated patch: PORTREVISION reset
Comment 3 Anton Saietskii 2023-06-18 13:28:03 UTC
Created attachment 242866 [details]
poudriere build log
Comment 4 Dan Langille freebsd_committer freebsd_triage 2023-06-18 13:31:30 UTC
(In reply to Daniel Engberg from comment #1)
By we, I hope you mean you. ;) I'm AFK for a while.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-06-18 13:38:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=42aeff21afcc5ec3d537fdbeca2fefc09bdcd9e7

commit 42aeff21afcc5ec3d537fdbeca2fefc09bdcd9e7
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2023-06-18 13:36:22 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2023-06-18 13:36:22 +0000

    net/syncthing: Update to 1.23.5

    re: https://github.com/syncthing/syncthing/releases/tag/v1.23.5

    PR:             272036

 net/syncthing/Makefile | 3 +--
 net/syncthing/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2023-06-18 14:25:55 UTC
Likely released issue, https://github.com/syncthing/syncthing/issues/8421
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2023-06-18 14:26:07 UTC
Err... related
Comment 8 Dan Langille freebsd_committer freebsd_triage 2023-06-18 15:16:43 UTC
(In reply to Daniel Engberg from comment #7)
I wish I had time now to investigate that, but I do not.

"Using Go 1.19.8 it works but fails using Go 1.20.3"

I'm AFK most of the time right now.
Comment 9 Anton Saietskii 2023-07-07 14:16:04 UTC
Created attachment 243302 [details]
patch for update
Comment 10 Anton Saietskii 2023-07-07 14:19:55 UTC
Created attachment 243303 [details]
poudriere build log

Bugfixes:
    #7638: favicon not working Firefox & derivative browsers
    #8899: Omitting %s from LDAP bind DN sends corrupted bind DN string to LDAP server
    #8920: Untrusted device should be disallowed from being an introducer
    #8960: relaysrv and discosrv docker images haven't been updated for more than year
Comment 11 Anton Saietskii 2023-07-12 15:02:55 UTC
Created attachment 243354 [details]
screenshot with 1.23.6 running
Comment 12 Dan Langille freebsd_committer freebsd_triage 2023-07-30 23:59:55 UTC
The commit for this is https://cgit.freebsd.org/ports/commit/?id=3e1bdb56d6eb37603f21d0c8a1b6be3a79a15569

I included the wrong PR in the commit message. 260085 - Copied here

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3e1bdb56d6eb37603f21d0c8a1b6be3a79a15569

commit 3e1bdb56d6eb37603f21d0c8a1b6be3a79a15569
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2023-07-30 20:49:32 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2023-07-30 23:55:25 +0000

    net/syncthing: Update to 1.23.6

    re: https://github.com/syncthing/syncthing/releases/tag/v1.23.6

    PR:             260085

 net/syncthing/Makefile | 2 +-
 net/syncthing/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 13 Dan Langille freebsd_committer freebsd_triage 2023-07-31 00:00:17 UTC
Thank you.