Bug 272045 - graphics/frei0r: update to 2.3.0
Summary: graphics/frei0r: update to 2.3.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL: https://github.com/dyne/frei0r/releas...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-17 16:58 UTC by Olivier Duchateau
Modified: 2023-06-18 19:08 UTC (History)
1 user (show)

See Also:
jhale: maintainer-feedback+


Attachments
Patch to update graphics/frei0r (2.51 KB, patch)
2023-06-17 16:58 UTC, Olivier Duchateau
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2023-06-17 16:58:45 UTC
Created attachment 242838 [details]
Patch to update graphics/frei0r

- Update to 2.3.0

Now tarballs are hosted on GitHUb
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-06-17 21:49:41 UTC
Binaries are hosted on GitHub, not release (static) tarballs.

DISTVERSIONPREFIX should be placed before DISTVERSION

Having a very quick look it also seems like upstream forgot to update versioning, https://github.com/dyne/frei0r/blob/v2.3.0/CMakeLists.txt#L6

Any testing done?
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2023-06-17 22:01:29 UTC
(In reply to Daniel Engberg from comment #1)
I caught that versioning error too. The “extra-patches” would theoretically need updated as well, but I’ve been working on overhauling the frei0r ports for easier future maintenance and splitting out the cairo plugins. Admittedly, I shoved this on the back burner too long, but I’m pretty much finished with the update.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-06-18 19:05:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c3570df406b90a78b22972f24146ca662dd8cd75

commit c3570df406b90a78b22972f24146ca662dd8cd75
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2023-06-18 18:23:21 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2023-06-18 19:04:46 +0000

    graphics/frei0r*: Update to 2.3.0 [1]

    Split cairo-dependent plugins out into graphics/frei0r-plugins-cairo.

    Shift pkg-plist and several variables out into the slave ports for
    easier maintainence, including PORTREVISION to facilitate usage of
    PORTREVISION bump scripts.

    Convert "extra" patches into regular patches for easier future
    maintainence.

    Ensure optional plugins are the same version as the frei0r base.

    https://github.com/dyne/frei0r/releases/tag/v2.3.0

    PR:             272045 [1]
    Reported by:    Olivier Duchateau <duchateau.olivier@gmail.com> [1]

 graphics/Makefile                                  |   1 +
 graphics/frei0r-plugins-cairo/Makefile (new)       |  11 ++
 graphics/frei0r-plugins-cairo/pkg-plist (new)      |   4 +
 graphics/frei0r-plugins-gavl/Makefile              |   8 +-
 graphics/frei0r-plugins-gavl/pkg-plist (new)       |   3 +
 graphics/frei0r-plugins-opencv/Makefile            |   8 +-
 graphics/frei0r-plugins-opencv/pkg-plist (new)     |   2 +
 graphics/frei0r-plugins/Makefile                   |  32 +++---
 graphics/frei0r/Makefile                           |  80 +++++--------
 graphics/frei0r/distinfo                           |   6 +-
 .../frei0r/files/extra-patch-CMakeLists.txt (gone) |  17 ---
 .../frei0r/files/extra-patch-frei0r-plugins (gone) | 125 ---------------------
 graphics/frei0r/files/patch-CMakeLists.txt (new)   |  59 ++++++++++
 .../files/patch-src_filter_CMakeLists.txt (new)    |  17 +++
 .../files/patch-src_mixer2_CMakeLists.txt (new)    |  17 +++
 graphics/frei0r/pkg-plist                          |  21 +++-
 graphics/frei0r/version.mk (new)                   |   1 +
 17 files changed, 197 insertions(+), 215 deletions(-)
Comment 4 Jason E. Hale freebsd_committer freebsd_triage 2023-06-18 19:08:46 UTC
Port has been updated to 2.3.0. I have been working on this for a while and took a different course. Thanks for your effort, just the same!