Bug 272105 - multimedia/ffnvcodec-headers not PREFIX-safe
Summary: multimedia/ffnvcodec-headers not PREFIX-safe
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mikhail Teterin
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2023-06-20 20:28 UTC by Mikhail T.
Modified: 2023-06-23 06:49 UTC (History)
1 user (show)

See Also:
iwtcex: maintainer-feedback+

Attachments
Add PREFIX to MAKE_ARGS (373 bytes, patch)
2023-06-20 20:28 UTC, Mikhail T. 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2023-06-20 20:28:39 UTC 
Created attachment 242898 [details]
Add PREFIX to MAKE_ARGS

Without the patch, the vendor's code installs under ${STAGEDIR}/usr/local
Comment 1 Alex S 2023-06-20 20:38:41 UTC 
Looks fine to me.
Comment 2 Mikhail T. 2023-06-20 20:40:49 UTC 
(In reply to Alex S from comment #1)
> Looks fine to me.

Hard to believe:

% make -C /usr/ports/multimedia/ffnvcodec-headers clean check-plist
...
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: /usr/local/include/ffnvcodec/dynlink_cuda.h
Error: Orphaned: /usr/local/include/ffnvcodec/dynlink_cuviddec.h
Error: Orphaned: /usr/local/include/ffnvcodec/dynlink_loader.h
Error: Orphaned: /usr/local/include/ffnvcodec/dynlink_nvcuvid.h
Error: Orphaned: /usr/local/include/ffnvcodec/nvEncodeAPI.h
Error: Orphaned: /usr/local/lib/pkgconfig/ffnvcodec.pc
Error: Orphaned: @dir /usr/local/include/ffnvcodec
Error: Orphaned: @dir /usr/local/include
Error: Orphaned: @dir /usr/local/lib/pkgconfig
Error: Orphaned: @dir /usr/local/lib
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: include/ffnvcodec/dynlink_cuda.h
Error: Missing: include/ffnvcodec/dynlink_cuviddec.h
Error: Missing: include/ffnvcodec/dynlink_loader.h
Error: Missing: include/ffnvcodec/dynlink_nvcuvid.h
Error: Missing: include/ffnvcodec/nvEncodeAPI.h
Error: Missing: libdata/pkgconfig/ffnvcodec.pc
===> Error: Plist issues found.
*** Error code 1
Comment 3 Alex S 2023-06-20 20:51:34 UTC 
(In reply to Mikhail T. from comment #2)

Well, that is the sentence that confirms that your patch has been approved (the + flag alone don't signify approval, only that the feedback has been given). What else do you want?
Comment 4 Mikhail T. 2023-06-20 20:53:16 UTC 
> Well, that is the sentence that confirms that your patch has been approved

Apologies. I (mis)took the sentence as a claim, that the port "looks fine" as is -- and that the patch is not needed :-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-06-20 21:13:12 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=92f0af65f2edd6e57e25784360798acc2dc84748

commit 92f0af65f2edd6e57e25784360798acc2dc84748
Author:     Mikhail Teterin <mi@FreeBSD.org>
AuthorDate: 2023-06-20 21:11:30 +0000
Commit:     Mikhail Teterin <mi@FreeBSD.org>
CommitDate: 2023-06-20 21:11:30 +0000

    multimedia/ffnvcodec-headers: explicitly set PREFIX

    Without this, upstream's Makefile uses /usr/local, which may be
    incorrect on systems with unusual PREFIX.

    PR:     272105
    Approved by: Alex S. (for multimedia@)

 multimedia/ffnvcodec-headers/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-06-23 06:49:08 UTC 
^Triage: assign to committer who resolved the issue.

Closing.