Created attachment 242985 [details] Patch for png Compile and runtime tested on FreeBSD 13.2-RELEASE (aarch64) (make, make check-plist, make test) Compile and runtime tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist, make test) Poudriere testport OK 13.2-RELEASE (amd64) Tested with following consumers in 13.2-RELEASE (amd64) using Poudriere: archivers/deutex astro/astrometry astro/celestia astro/celestia-gtk astro/gnuastro astro/siril astro/sunclock astro/xephem astro/xplanet astro/xtide audio/audacity audio/bespokesynth - Fails, unrelated: Source/MainComponent.cpp:167:47: error: only virtual member functions can be marked 'override' audio/csound audio/dexed audio/ebumeter audio/enscribe audio/ocp audio/sox audio/tetraproc audio/timidity++ audio/zita-at1 audio/zita-bls1 audio/zita-dpl1 audio/zita-mu1 audio/zita-rev1 audio/zynaddsubfx benchmarks/glmark2 biology/emboss biology/ncbi-toolkit biology/protomol biology/seaview biology/ucsc-userapps cad/PrusaSlicer cad/antimony cad/appcsxcad cad/brlcad cad/csxcad cad/freecad cad/gmsh cad/horizon-eda cad/kicad cad/kicad-devel cad/ldview cad/lepton-eda cad/opencascade cad/openvsp cad/py-gmsh cad/qcsxcad cad/solvespace cad/sumo comms/flamp comms/flcluster comms/fldigi comms/flmsg comms/flrig comms/xastir comms/xnecview converters/wkhtmltopdf databases/grass7 databases/grass8 databases/rrdtool databases/rrdtool12 deskutils/coolreader deskutils/gnome-photos deskutils/xfce4-tumbler devel/agar devel/allegro devel/allegro5 devel/apitrace devel/bennugd-modules devel/cvsgraph devel/directfb devel/efl devel/electron19 devel/electron21 devel/electron22 devel/electron23 devel/electron24 devel/godot devel/godot-tools devel/godot2 devel/godot2-tools devel/godot35 devel/godot35-tools devel/juce devel/kyra devel/libslang2 devel/libzvbi devel/p5-SDL devel/py-game devel/py-game_sdl2 devel/qt6-base devel/qt6-tools devel/rgbds devel/root devel/sfml1 devel/smooth devel/tex-web2c devel/upp editors/abiword editors/calligra editors/emacs editors/emacs-devel editors/libreoffice editors/openoffice-4 editors/openoffice-devel editors/pdfedit editors/ted editors/vscode emulators/atari800 emulators/cemu emulators/dolphin-emu emulators/dosbox emulators/dosbox-staging emulators/dosbox-x emulators/emu64 emulators/fs-uae emulators/fuse emulators/fuse-utils emulators/hatari emulators/libretro-pcsx2 emulators/mgba emulators/mupen64plus-core emulators/mupen64plus-video-rice emulators/nestopia emulators/openmsx emulators/pcsx2 emulators/ppsspp emulators/qemu emulators/qemu-devel emulators/qemu6 emulators/qemu7 emulators/rpcs3 emulators/snes9x-gtk emulators/stella emulators/teo emulators/tic-80 emulators/vba emulators/vice emulators/virtualbox-ose emulators/virtualbox-ose-legacy emulators/virtualbox-ose-nox11 emulators/virtualbox-ose-nox11-legacy emulators/visualboyadvance-m emulators/zsnes games/0ad games/54321 games/DDNet games/Doom64EX games/OpenTomb games/SRB2 games/ace-of-penguins games/alephone games/alienarena games/allacrost games/aquaria games/armagetronad games/augustus games/avoision games/barony games/briquolo games/burrtools games/caph games/chocolate-doom games/colobot games/cretan-hubris games/crispy-doom games/criticalmass games/diaspora games/domino-chain games/dxx-rebirth games/easyrpg-player games/eboard games/edge games/eduke32 games/egl games/el games/endless-sky games/enigma games/ensemblist games/eureka games/exult games/exult-devel games/ezquake games/fbg2 games/fheroes2 games/flightgear games/flyhard games/foobillard games/freedroid games/freedroidrpg games/freeminer games/freeorion games/freesynd games/frogatto games/fs2open games/gemrb games/glaxium games/gltron games/gnubg games/gracer games/gtkradiant games/hedgewars games/hyperrogue games/irrlamb games/ivan games/jigzo games/joequake games/julius games/lbreakout2 games/legend-of-edgar games/lincity games/lugaru games/macopix games/manaplus games/megaglest games/minetest games/motogt games/naev - Fails, unrelated ld: error: duplicate symbol: nglGenerateMipmap games/nazghul games/netradiant games/neverball games/nexuiz games/nxengine games/oblige games/odamex games/oolite games/openage - Fails, unrelated libopenage/main.h:15 expected identifier after 'namespace' games/openbor games/openbor3482 games/openbor3711 games/openbor3979 games/openbor4432 games/opencity games/openclonk games/openjk games/openomf games/openrct2 games/opensonic games/opensurge games/openttd games/penguin-command games/pingus games/pipewalker games/powder-toy games/powder-toy-devel games/powermanga games/prboom games/prboom-plus games/py-fife games/q2p games/q2pro games/quadra games/quake2max games/quakeforge games/qudos games/r1q2 games/renpy games/residualvm games/scummvm games/scummvm-tools games/shaaft games/simutrans games/springlobby - Fails due to games/spring, unrelated ld: error: undefined symbol: streflop_libm::__inline_isnanf(float) games/stratagus games/supertux2 games/supertuxkart games/taisei games/tenebrae games/thegrind games/tome4 games/tome4-beta games/toppler games/torcs games/tuxpaint games/ufoai games/uqm games/valyriatear games/vamos games/vavoom games/vultures-eye games/wargus games/warzone2100 games/wesnoth games/widelands games/wizznic games/xbubble games/xglk games/xmoto games/xonotic games/zoom german/webalizer2 graphics/GraphicsMagick graphics/ImageMagick6 graphics/ImageMagick7 graphics/R-cran-png graphics/aaphoto graphics/aeskulap graphics/airsaned graphics/apngasm graphics/apngdis graphics/appleseed - Fails, unrelated /usr/local/include/OpenImageIO/platform.h:105:6: error: "This version of OIIO is meant to work only with C++14 and above" graphics/argyllcms graphics/art graphics/aseprite graphics/autopano-sift-c graphics/autotrace graphics/azpainter graphics/azpainterb graphics/blender graphics/blender-lts29 graphics/bmeps graphics/cairo graphics/cairomm graphics/cfdg graphics/cimg graphics/cloudcompare graphics/cptutils graphics/crw graphics/darktable graphics/dataplot graphics/dcmtk graphics/devil graphics/dia graphics/digikam graphics/electricsheep - Fails, unrelated (seems to be a FFmpeg issue) Source/MainComponent.cpp:167:47: error: only virtual member functions can be marked 'override' graphics/embree graphics/enblend graphics/epsonscan2 graphics/exrtools graphics/farbfeld graphics/feh graphics/flam3 graphics/flif graphics/flphoto graphics/fotoxx graphics/fpc-libpng graphics/fv graphics/gd graphics/gdal graphics/gdk-pixbuf2 graphics/gdtclft graphics/geeqie graphics/gegl graphics/geomorph graphics/gimageview graphics/gimp-app graphics/glosm graphics/glpng graphics/glvis graphics/gmic graphics/gmic-qt graphics/gnash graphics/gource graphics/goxel graphics/grads graphics/grafx2 graphics/graphviz graphics/grx graphics/gstreamer1-plugins-gl graphics/gstreamer1-plugins-png graphics/gthumb graphics/guetzli graphics/gwenview graphics/hiptext graphics/hugin graphics/icoutils graphics/ida graphics/imageworsener graphics/imlib2 graphics/imv graphics/inkscape graphics/ipe graphics/jbig2dec graphics/jp2a graphics/kmscube graphics/krita graphics/largetifftools graphics/lensfun graphics/leptonica graphics/libafterimage graphics/libavif graphics/libbpg graphics/libgfx graphics/libgxps graphics/libheif graphics/libimg graphics/libjxl graphics/libpano13 graphics/libqrencode graphics/librasterlite2 graphics/librsvg2 graphics/librsvg2-rust graphics/libsvg graphics/libwmf graphics/libwmf-nox11 graphics/libzmf graphics/luminance-qt5 graphics/magnum-plugins graphics/maim graphics/mandelbulber graphics/mapcache graphics/mapnik graphics/mapserver graphics/matplotplusplus graphics/meh graphics/metapixel graphics/ming graphics/mirtk graphics/mozjpeg graphics/mscgen graphics/mtpaint graphics/mypaint graphics/netpbm graphics/ocaml-images - Fails, unrelated Checking graphics compilability: open Graphics... *** omake error: graphics/ocrad graphics/open3d graphics/opencv graphics/openfx-arena graphics/openimageio graphics/openjpeg graphics/openjpeg15 graphics/openmvs graphics/openslide graphics/optar graphics/optipng graphics/osg graphics/osg34 graphics/oyranos graphics/p5-Image-PNG-Libpng graphics/p5-Image-PNG-QRCode graphics/p5-Image-Scale graphics/p5-Imager graphics/p5-PGPLOT graphics/p5-ming graphics/pcl-pointclouds graphics/pecl-qrencode graphics/pgplot graphics/php80-gd graphics/php81-gd graphics/php82-gd graphics/php83-gd graphics/piglit graphics/plotutils graphics/png2html graphics/png2ico graphics/pngcrush graphics/pngnq graphics/pngquant graphics/pngrewrite graphics/pngwriter graphics/podofo graphics/podofo09 graphics/poppler graphics/poppler-glib graphics/poppler-qt5 graphics/poppler-qt6 graphics/poppler-utils graphics/povray36 graphics/povray37 graphics/povray38 graphics/py-ming graphics/py-openimageio graphics/qt6-3d graphics/qt6-imageformats graphics/qt6-svg graphics/qt6-wayland graphics/radius-engine graphics/rawstudio graphics/rawtherapee graphics/ruby-gd graphics/sane-airscan graphics/sane-backends graphics/scale2x graphics/scantailor graphics/sdl2_image graphics/sdl_image graphics/sdump graphics/seexpr graphics/simage graphics/simpleviewer graphics/skanlite graphics/skanpage graphics/swfmill graphics/synfig graphics/tif22pnm graphics/timg graphics/ufraw graphics/vigra graphics/vips graphics/visprint graphics/vv graphics/wdune graphics/webp graphics/xcftools graphics/xfig graphics/xli graphics/xmedcon graphics/xpaint graphics/xpdf graphics/xpdf3 graphics/xpdf4 graphics/xsane graphics/xv graphics/xv-m17n graphics/yafaray graphics/zgv graphics/zimg graphics/zint japanese/awffull japanese/gd japanese/webalizer japanese/xv java/openjdk11 java/openjdk11-jre java/openjdk17 java/openjdk17-jre java/openjdk18 java/openjdk19 lang/racket mail/spamprobe mail/thunderbird math/R math/brial math/giacxcas math/gnuplot math/grace math/m4ri math/mathgl math/openturns math/ploticus math/ploticus-nox11 math/py-matplotlib math/py-matplotlib2math/reduce math/sage - Fails due to math/fricas (build/runaway) math/vtk8 math/vtk9 misc/adios2 misc/libemos misc/magicpoint misc/nn-insight misc/openmvg misc/py-torchvision misc/visp misc/vxl misc/wmweather+ multimedia/aribb24 multimedia/avidemux multimedia/avidemux-cli multimedia/avidemux-plugins multimedia/avidemux-qt5 multimedia/butt multimedia/dvdauthor multimedia/emby-server multimedia/emby-server-devel multimedia/ffmpegthumbnailer multimedia/gavl multimedia/gmerlin multimedia/gpac-libgpac multimedia/harvid multimedia/kodi multimedia/libxine multimedia/lives - Fails, unrelated (FFmpeg issue) ../ContentDecoder/Frame.h:106:23: error: use of undeclared identifier 'avpicture_get_size' multimedia/mencoder multimedia/mjpegtools multimedia/mplayer multimedia/obs-recursion-effect multimedia/obs-text-pthread multimedia/ogmrip multimedia/opentoonz multimedia/vlc multimedia/xawtv multimedia/xine net/freeswitch net/guacamole-server net/libvncserver net/spiritvnc net/tigervnc-viewer net-im/ejabberd net-im/sayaka net-im/signal-desktop net-im/telegram-purple net-im/toxic net-mgmt/driftnet net-mgmt/mrtg net-mgmt/nagios4 net-mgmt/observium net-mgmt/xymon-server net-p2p/amule news/knews polish/webalizer2 portuguese/webalizer-pt_BR portuguese/webalizer-pt_PT print/cups-filters print/fig2dev print/fontforge print/freetype2 print/ft2demos print/ghostscript10 print/ghostscript7-base print/ghostscript8-base print/ghostscript9-agpl-base print/ghostscript9-agpl-x11 print/gl2ps print/hp2xx print/libharu print/lilypond-devel print/limereport print/miktex print/panda print/pdf-tools print/photoprint print/pslib print/scribus-devel print/tex-basic-engines print/tex-dvipdfmx print/tex-luatex print/tex-xetex print/texlive-base print/transfig russian/gd science/InsightToolkit science/InsightToolkit501 science/afni science/chrono science/dakota science/dlib-cpp science/eccodes science/elmerfem science/geant4 science/gnudatalanguage science/grib_api science/h5utils science/lammps science/liggghts science/massxpert science/molscript science/octopus science/openems science/openmc science/orthanc science/paraview science/py-dlib science/py-pymol science/py-tensorflow science/scidavis science/teem science/zotero sysutils/graffer sysutils/logstalgia sysutils/pfstat sysutils/tracker-miners textproc/fixrtf textproc/fldiff textproc/gladtex textproc/htmldoc textproc/obsidian textproc/scim-kmfl-imengine textproc/wv ukrainian/gd ukrainian/webalizer www/analog www/awffull www/chromium www/dillo2 www/firefox www/firefox-esr www/geolizer www/ilias www/iridium www/kf5-khtml www/librewolf www/links www/netsurf www/qt5-webengine www/qt5-webkit www/qt6-webengine www/tor-browser www/ungoogled-chromium www/webalizer www/webkit2-gtk3 www/webkit2-gtk4 www/wt x11/alttab x11/bbdock x11/eaglemode x11/fbdesk x11/fnott x11/fuzzel x11/grim x11/jgmenu x11/kitty x11/mrxvt x11/mrxvt-devel x11/nxcomp x11/slim x11/swayimg x11/virtboard x11/xautomation x11/xcursorgen x11/xforward x11/xloadimage x11-fm/xfe x11-toolkits/fltk x11-toolkits/fox14 x11-toolkits/fox16 x11-toolkits/fox17 x11-toolkits/gnustep-gui x11-toolkits/gtk40 x11-toolkits/irrlicht x11-toolkits/libgdiplus x11-toolkits/ntk x11-toolkits/open-motif x11-toolkits/open-motif-devel x11-toolkits/p5-Prima x11-toolkits/p5-Tk x11-toolkits/pangolin x11-toolkits/qt5-gui x11-toolkits/qt6-declarative x11-toolkits/qt6-quick3d x11-toolkits/qt6-quicktimeline x11-toolkits/qt6-shadertools x11-toolkits/wxgtk30 x11-toolkits/wxgtk32 x11-toolkits/xmhtml x11-wm/afterstep-stable x11-wm/compiz x11-wm/fvwm2 x11-wm/fvwm3 x11-wm/jwm x11-wm/libwraster x11-wm/pekwm x11-wm/skippy-xd x11-wm/vtwm x11-wm/wayfire x11-wm/windowmaker Related failures: mail/thunderbird www/firefox www/tor-browser www/librewolf www/firefox-esr All fail with "DEBUG: | ld: error: undefined symbol: png_get_acTL" during configure stage
Found the issue with Mozilla related ports (typo in patch file), rebuilding...
Created attachment 242987 [details] Patch for png v2 Fix typo in Makefile so apng patch actually applies This fixes all Mozilla ports mentioned above
Friendly ping
This will still take a bit to verify/qualify due to the amount of consumers to rebuild (on -CURRENT with clang 16)
Moin moin Please ask for an exp-run. mfg Tobias
The comments in the Makefile for #PATCHFILES= ${DISTNAME}-apng.patch.gz:-p1 PATCHFILES= lib${PORTNAME}-1.6.39-apng.patch.gz:-p1 and similarly PATCH_SITES should probably be removed or some explanation added why the old line remains.
Hi, I'd like to request an exp-run on behalf of desktop@ Best regards, Daniel
(In reply to Tobias C. Berner from comment #6) Sure, I'll add that.
Exp-run looks fine
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3add5bcc2e5ebd97bccdc235448be7723e54da76 commit 3add5bcc2e5ebd97bccdc235448be7723e54da76 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-07-28 17:26:48 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-07-28 17:26:54 +0000 graphics/png: Update to 1.6.40 Changelog: https://github.com/glennrp/libpng/blob/v1.6.40/CHANGES PR: 272200 Reviewed by: desktop (tcberner) Sponsored by: Blinkinblox Exp-run by: antoine graphics/png/Makefile | 12 ++++++++---- graphics/png/distinfo | 6 +++--- graphics/png/pkg-plist | 2 +- 3 files changed, 12 insertions(+), 8 deletions(-)