Bug 272223 - audio/Maaate: fix build with clang 16
Summary: audio/Maaate: fix build with clang 16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks: 271047
  Show dependency tree / graph
 
Reported: 2023-06-26 12:42 UTC by Marcin Cieślak
Modified: 2023-06-29 11:45 UTC (History)
1 user (show)

See Also:

Attachments
patch "register" keyword out (2.77 KB, patch)
2023-06-26 12:42 UTC, Marcin Cieślak 		no flags Details | Diff
remove "register" keyword (3.48 KB, patch)
2023-06-28 10:49 UTC, Marcin Cieślak 		fernape: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Cieślak 2023-06-26 12:42:51 UTC 
Created attachment 243011 [details]
patch "register" keyword out

Attached patch fixes the build of Maate with clang 16
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-06-28 10:15:04 UTC 
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.

Marcin, can you provide a patch to be applied to the ports tree? So, the output of git diff or similar? Your patch should be a patch in files/ to be applied automatically.


Thanks!
Comment 2 Marcin Cieślak 2023-06-28 10:49:47 UTC 
Created attachment 243054 [details]
remove "register" keyword

Sure I can, is git format-patch okay like this?
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-06-28 11:03:27 UTC 
(In reply to Marcin Cieślak from comment #2)
Yes, thanks!
Comment 4 Marcin Cieślak 2023-06-28 11:13:01 UTC 
Thanks for picking this up so quickly!
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2023-06-29 11:45:18 UTC 
Committed,

Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-06-29 11:45:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=da510041c696da12e6fe40355ab615c98f317f30

commit da510041c696da12e6fe40355ab615c98f317f30
Author:     Marcin Cieślak <saper@saper.info>
AuthorDate: 2023-06-28 11:03:42 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-06-29 11:45:01 +0000

    audio/Maaate: fix build with clang 16

    Patch the "register" keyword out.

    PR:             272223
    Reported by:    saper@saper.info (maintainer)

 audio/Maaate/files/patch-no-register (new) | 84 ++++++++++++++++++++++++++++++
 1 file changed, 84 insertions(+)