Bug 272410 - audio/id3mtag: Update to 0.81
Summary: audio/id3mtag: Update to 0.81
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-07 10:21 UTC by Marc Schoolderman
Modified: 2023-07-30 23:02 UTC (History)
1 user (show)

See Also:

Attachments
git diff (2.16 KB, patch)
2023-07-07 10:21 UTC, Marc Schoolderman 		no flags Details | Diff
Updated patch to ports tree (2.11 KB, patch)
2023-07-12 11:13 UTC, Marc Schoolderman 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Schoolderman 2023-07-07 10:21:24 UTC 
Created attachment 243299 [details]
git diff

Changes in id3 0.81:
- Will now also update ID3v2 tags by default (if they are present)
- Add support for POPM frames
- Fixes bugs (thanks geeknik!)
- Replaces code removed by C++17 to fix compilation issues in FreeBSD 14

Changes in the package:
- maintainer email address changed (the old one still works for now)
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2023-07-07 10:21:24 UTC 
Maintainer informed via mail
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-07-11 08:31:16 UTC 
Are you the maintainer?
Comment 3 Marc Schoolderman 2023-07-11 09:58:37 UTC 
(In reply to Robert Clausecker from comment #2)
Yes.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-07-11 12:07:23 UTC 
Thank you for the submission.  Here are some notes:

 - there is no need to add an option for shell completion files.
   Just install them unconditionally.
 - please install shell completion files into the directories
   specified in § 6.31 Porter's Handbook.  Your patch uses what
   looks like to be the wrong directory.

Please check and resubmit.
Comment 5 Marc Schoolderman 2023-07-12 11:13:05 UTC 
Created attachment 243351 [details]
Updated patch to ports tree

This makes installing the bash-completion files unconditional, and also picks a better name for the installed ports file (changes have been verified to be working when bash-completion is installed).
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-07-28 09:57:02 UTC 
Sorry for the delay, I was on vacation.  Will commit with my next batch.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-07-30 23:00:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f53717a5ad092b840f7c0884094bff1f74623170

commit f53717a5ad092b840f7c0884094bff1f74623170
Author:     Marc Schoolderman <info@marcschoolderman.nl>
AuthorDate: 2023-07-28 09:55:37 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-07-30 22:59:02 +0000

    audio/id3mtag: update to 0.81

    Changes in id3 0.81:
    - Will now also update ID3v2 tags by default (if they are present)
    - Add support for POPM frames
    - Fixes bugs (thanks geeknik!)
    - Replaces code removed by C++17 to fix compilation issues in FreeBSD 14

    Changes in the package:
    - maintainer email address changed (the old one still works for now)
    - bash-completion files are now installed unconditionally
    - bash-completion files are now installed into the right places

    PR:             272410

 audio/id3mtag/Makefile | 28 +++++++++++++---------------
 audio/id3mtag/distinfo |  5 +++--
 2 files changed, 16 insertions(+), 17 deletions(-)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-07-30 23:02:47 UTC 
Thank you for your contribution.