Bug 272488 - security/sudo: patch to add sssd-devel option
Summary: security/sudo: patch to add sssd-devel option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-13 20:16 UTC by Dan Langille
Modified: 2024-01-24 19:39 UTC (History)
0 users

See Also:
garga: maintainer-feedback+

Attachments
patch for SSSD_DEVEL (1.29 KB, patch)
2023-07-13 20:16 UTC, Dan Langille 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Langille freebsd_committer freebsd_triage 2023-07-13 20:16:04 UTC 
Created attachment 243372 [details]
patch for SSSD_DEVEL

security/sudo already allows for the use of security/sssd (SSSD)

This patch allows for selecting security/sssd-devel (SSSD_DEVEL) instead.

We are using this patch here.
Comment 1 Renato Botelho freebsd_committer freebsd_triage 2023-07-14 12:28:24 UTC 
Hi Dan,

It looks good to me.  Go ahead and get it committed.

Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-07-14 13:07:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c90c4cc7030b96337f094c4f72c1708cf89381b7

commit c90c4cc7030b96337f094c4f72c1708cf89381b7
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2023-07-14 13:05:34 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2023-07-14 13:06:49 +0000

    security/sudo: add sssd-devel option

    security/sudo already allows for the use of security/sssd (SSSD)

    This patch allows for selecting security/sssd-devel (SSSD_DEVEL)
    instead.

    PR:             272488

 security/sudo/Makefile | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Comment 3 Dan Langille freebsd_committer freebsd_triage 2023-07-14 13:09:21 UTC 
Committed, thank you.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-07-26 02:00:49 UTC 
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f8def0700fcd7e0e9c53a41c67dd877b41839151

commit f8def0700fcd7e0e9c53a41c67dd877b41839151
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2023-07-14 13:05:34 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2023-07-26 01:57:33 +0000

    security/sudo: add sssd-devel option

    security/sudo already allows for the use of security/sssd (SSSD)

    This patch allows for selecting security/sssd-devel (SSSD_DEVEL)
    instead.

    PR:             272488
    (cherry picked from commit c90c4cc7030b96337f094c4f72c1708cf89381b7)

 security/sudo/Makefile | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Comment 5 Dan Langille freebsd_committer freebsd_triage 2024-01-24 19:36:02 UTC 
This was reverted via https://cgit.freebsd.org/ports/commit/security/sudo/Makefile?id=dd773c1540388b14692001643e323a556ed2d445

My plan is one of these:

* amend sssd-devel to not require sudo (it doesn't, it works here without sudo)
* promote sssd-devel to sssd (it's working OK here)
Comment 6 Dan Langille freebsd_committer freebsd_triage 2024-01-24 19:39:32 UTC 
See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272571 which plans to remove the sudo dependency of sssd-devel