Bug 272523 - games/pysolfc-2.20.1 is incompatible with pillow-10
Summary: games/pysolfc-2.20.1 is incompatible with pillow-10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-15 21:13 UTC by sven.a.jonsson
Modified: 2023-07-24 04:32 UTC (History)
2 users (show)

See Also:
kai: maintainer-feedback+


Attachments
pysolfc-2.21.0.patch (1.18 KB, patch)
2023-07-17 15:25 UTC, Kai Knoblich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sven.a.jonsson 2023-07-15 21:13:00 UTC
An attempt to start pysolfc with pillow-10.0 installed gives the following result:

pysolfc
Traceback (most recent call last):
  File "/usr/local/bin/pysolfc", line 36, in <module>
    from pysollib.main import main  # noqa: E402,I202
  File "/usr/local/lib/python3.9/site-packages/pysollib/main.py", line 30, in <module>
    from pysollib.app import Application
  File "/usr/local/lib/python3.9/site-packages/pysollib/app.py", line 32, in <module>
    from pysollib.actions import PysolMenubar
  File "/usr/local/lib/python3.9/site-packages/pysollib/actions.py", line 28, in <module>
    from pysollib.help import help_about, help_html
  File "/usr/local/lib/python3.9/site-packages/pysollib/help.py", line 29, in <module>
    from pysollib.pysoltk import HTMLViewer
  File "/usr/local/lib/python3.9/site-packages/pysollib/pysoltk.py", line 28, in <module>
    from pysollib.ui.tktile.tkutil import *  # noqa: F401,F403
  File "/usr/local/lib/python3.9/site-packages/pysollib/ui/tktile/tkutil.py", line 250, in <module>
    class PIL_Image(ImageTk.PhotoImage):
  File "/usr/local/lib/python3.9/site-packages/pysollib/ui/tktile/tkutil.py", line 291, in PIL_Image
    def resize(self, xf, yf, resample=Image.ANTIALIAS):
AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'


Upstream has fixed this in 2.21.0 beta.
Possible workarounds:
* downgrade pillow to 9.5.0
* or build the port with the PILLOW option off.
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2023-07-17 15:24:23 UTC
(In reply to sven.a.jonsson from comment #0)

Thanks you for the report. I already have a patch that I have not been able to test yet due to current issues with my build system.

I think that the said problems with the builder should be solved by the weekend and if the patch can then be built successfully, the update for PySolFC 2.21.0 should land in the ports tree right away.
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2023-07-17 15:25:03 UTC
Created attachment 243435 [details]
pysolfc-2.21.0.patch
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-07-18 11:42:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=57a6ad3984713bcdfd7cb4b67b177b0fecd525fd

commit 57a6ad3984713bcdfd7cb4b67b177b0fecd525fd
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2023-07-18 11:38:50 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2023-07-18 11:40:21 +0000

    games/pysolfc: Update to 2.21.0

    * Although it's a beta release it adds compatibility [1]
      for Pillow 10.0.

    Changelog:

    https://github.com/shlomif/PySolFC/blob/pysolfc-2.21.0/NEWS.asciidoc

    PR:             272523 [1]
    Reported by:    sven.a.jonsson@bahnhof.se [1]
    MFH:            No (beta release, Pillow >= 10 not present in 2023Q3)

 games/pysolfc/Makefile | 2 +-
 games/pysolfc/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 4 Kai Knoblich freebsd_committer freebsd_triage 2023-07-18 11:45:18 UTC
(In reply to sven.a.jonsson from comment #0)

Issues with my builder still persist but I was able to build and test the 2.21.0 release of PySolFC hence I committed it to the main branch.

Once again thanks for the report!

I'll leave this bug a few days open for reference.
Comment 5 sven.a.jonsson 2023-07-18 19:54:00 UTC
It works perfectly, thanks for the quick response!
Comment 6 Kai Knoblich freebsd_committer freebsd_triage 2023-07-24 04:32:00 UTC
(In reply to sven.a.jonsson from comment #5)

That's nice, thanks for your feedback! I therefore close this bug.