Bug 272601 - net-mgmt/bind_exporter: please bump version to 0.5.0
Summary: net-mgmt/bind_exporter: please bump version to 0.5.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-19 14:38 UTC by Gert Doering
Modified: 2023-07-30 23:04 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (matt)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gert Doering 2023-07-19 14:38:26 UTC
FreeBSD currently ships bind_exporter 0.4.0, which fails to read bind statistics if there are unavailable zones (and bind returns <serial>-1</serial>).

The fix is in 0.5.0, released over a year ago.

Please bump the port accordingly.

I would append a patch, but I am not a Go person, and a "simple" substitution of 0.4.0 by 0.5.0 leads to strange error messages

===>  Building bind_exporter from github.com/prometheus-community/bind_exporter
go: finding module for package github.com/go-kit/log/level
go: finding module for package github.com/prometheus/client_golang/prometheus/collectors
bind_exporter.go:26:2: cannot query module due to -mod=vendor
bind_exporter.go:32:2: cannot query module due to -mod=vendor

... which is all gibberish to me.  So there is a bit more understanding needed.

For reference, here's the upstream ticket about the bind interop issue, fixed in 0.5.0

https://github.com/prometheus-community/bind_exporter/pull/97

thanks,

gert
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-07-29 09:45:58 UTC
If the maintainer times out, I can assist in updating the port.  Please ping me around 2023-08-02 if you don't get a response from the maintainer.
Comment 2 Matt Moriarity 2023-07-30 21:21:51 UTC
Sorry but I'm not running bind on FreeBSD anymore or running FreeBSD servers at all, so I can't easily test a change for this. Happy for someone else to take it.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-07-30 21:31:33 UTC
(In reply to Matt Moriarity from comment #2)

Thanks.  I'll take care of it.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-07-30 23:00:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e7cc77abf57583550c560b29c87944071a44dad5

commit e7cc77abf57583550c560b29c87944071a44dad5
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-07-30 21:32:49 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-07-30 22:59:10 +0000

    net-mgmt/bind_exporter: update to 0.6.1

    Maintainer no longer uses FreeBSD and agrees to pass on maintainership.
    Take maintainership and modernise port.

    Changelog: https://github.com/prometheus-community/bind_exporter/releases/tag/v0.6.1

    PR:             272601
    MFH:            2023Q3
    Approved by:    matt@mattmoriarity.com
    Reported by:    gert@greenie.muc.de

 net-mgmt/bind_exporter/Makefile | 34 +++-----------------------
 net-mgmt/bind_exporter/distinfo | 54 ++++-------------------------------------
 2 files changed, 8 insertions(+), 80 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-07-30 23:03:15 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b770c53eb47dff9a5e7574c4160f4af64933e049

commit b770c53eb47dff9a5e7574c4160f4af64933e049
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-07-30 21:32:49 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-07-30 23:01:42 +0000

    net-mgmt/bind_exporter: update to 0.6.1

    Maintainer no longer uses FreeBSD and agrees to pass on maintainership.
    Take maintainership and modernise port.

    Changelog: https://github.com/prometheus-community/bind_exporter/releases/tag/v0.6.1

    PR:             272601
    MFH:            2023Q3
    Approved by:    matt@mattmoriarity.com
    Reported by:    gert@greenie.muc.de

    (cherry picked from commit e7cc77abf57583550c560b29c87944071a44dad5)

 net-mgmt/bind_exporter/Makefile | 34 +++-----------------------
 net-mgmt/bind_exporter/distinfo | 54 ++++-------------------------------------
 2 files changed, 8 insertions(+), 80 deletions(-)