Bug 272610 - misc/tzdiff: update to 1.2
Summary: misc/tzdiff: update to 1.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-20 06:13 UTC by Yuichiro NAITO
Modified: 2023-08-01 04:13 UTC (History)
1 user (show)

See Also:

Attachments
tzdiff-distversion.patch (279 bytes, patch)
2023-07-22 14:04 UTC, Yuichiro NAITO 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuichiro NAITO 2023-07-20 06:13:38 UTC 
Tzdiff has been updated to 1.2 today. I made a pull request in GitHub to update
misc/tzdiff port. See the following URL. Thank you!

https://github.com/freebsd/freebsd-ports/pull/185
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-07-20 07:48:24 UTC 
Hi,

Please update your ports Makefile so it follows the same style as the examples in Porters Handbook. 
See https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github for more information

Also switch order of NO_*  and plist sections

Best regards,
Daniel
Comment 2 Yuichiro NAITO 2023-07-20 13:36:44 UTC 
(In reply to Daniel Engberg from comment #1)
Thanks for the comment. Would you check my fix in the following Pull Request. 

https://github.com/freebsd/freebsd-ports/pull/186

Is it as same as you intended?
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-07-21 16:27:41 UTC 
PORTVERSION --> DISTVERSION

Please migrate to bugzilla (here) as we don't support PRs via GitHub (read only mirror)

Looks good otherwise
Comment 4 Yuichiro NAITO 2023-07-22 14:03:25 UTC 
(In reply to Daniel Engberg from comment #3)
I'm confused about how to handle my patch. I had an suggestion to use GitHub in
another PR #271883. It was a patch for base. For Ports, a patch should be attached
in Bugzilla? I'm not sure current policy.

Anyway, my previous Pull Requests are already merged in Ports tree. I attach my 
patch to reflect your last comment. Please refer to 'tzdiff-distversion.patch'.
Comment 5 Yuichiro NAITO 2023-07-22 14:04:12 UTC 
Created attachment 243550 [details]
tzdiff-distversion.patch
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2023-07-29 10:34:35 UTC 
Hi,

Sorry for the late reply, currently we only support patches for "base" using GitHub while that's not the case for ports (also marked as read-only). Portmgr is looking into disabling PRs on GitHub to avoid confusion.

Best regards,
Daniel
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-07-30 15:20:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=99af3eef26c5b97f692bc3c56a62509d65d92d38

commit 99af3eef26c5b97f692bc3c56a62509d65d92d38
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-07-30 15:12:25 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-07-30 15:12:29 +0000

    misc/tzdiff: Fix style

    Fix some style issues

    PR:             272610

 misc/tzdiff/Makefile | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
Comment 8 Yuichiro NAITO 2023-08-01 04:13:29 UTC 
(In reply to Daniel Engberg from comment #6)
OK, I understand. Thanks for notifying me.