Created attachment 243526 [details] patch
Hello. Because of past breakages, I'm keeping azure ports/libraries very tight with the azure-cli* requirements. I will update azure-cli* to 2.50.0 this weekend and update msal together to 1.22.0. Thanks for the patch. Regards.
Brad, I have almost everything ready for the azure-cli upgrade, but I'm facing runtime issues. $ git log --pretty=oneline --abbrev-commit main...azure_cli_250 c66308c0c79b (HEAD -> azure_cli_250) sysutils/py-azure-cli: Update to 2.50.0 9fea96279522 sysutils/py-azure-cli-core: Update to 2.50.0 9243bf07d827 devel/py-azure-mgmt-apimanagement: Update to 4.0.0 365ff60d4b64 devel/py-azure-mgmt-containerservice: Update to 24.0.0 2d6fa2f6cbde devel/py-azure-mgmt-keyvault: Update to 10.2.2 0df0c0067811 devel/py-azure-mgmt-rdbms: Update to 10.2.0b10 44f42c1cda51 devel/py-azure-mgmt-recoveryservices: Update to 2.4.0 40d8c2f3c948 devel/py-azure-mgmt-resource: Update to 23.1.0b2 fb130ae907bc devel/py-azure-multiapi-storage: Update to 1.2.0 78d7a4d3dc92 devel/py-msal: Update to 1.22 $ az storage blob upload --container-name containertest --file /usr/ports/distfiles/azure-cli-core-2.50.0.tar.gz The command failed with an unexpected error. Here is the traceback: 'NoneType' object is not iterable Traceback (most recent call last): File "/usr/local/lib/python3.9/site-packages/knack/cli.py", line 233, in invoke cmd_result = self.invocation.execute(args) File "/usr/local/lib/python3.9/site-packages/azure/cli/core/commands/__init__.py", line 561, in execute self.commands_loader.load_arguments(command) File "/usr/local/lib/python3.9/site-packages/azure/cli/core/__init__.py", line 522, in load_arguments loader.load_arguments(command) # this adds entries to the argument registries File "/usr/local/lib/python3.9/site-packages/azure/cli/command_modules/storage/__init__.py", line 31, in load_arguments load_arguments(self, command) File "/usr/local/lib/python3.9/site-packages/azure/cli/command_modules/storage/_params.py", line 2404, in load_arguments help=sas_help.format(get_permission_help_string(t_file_system_permissions)), File "/usr/local/lib/python3.9/site-packages/azure/cli/command_modules/storage/_validators.py", line 870, in get_permission_help_string return ' '.join(['({}){}'.format(x[0], x[1:]) for x in allowed_values]) TypeError: 'NoneType' object is not iterable When I encounter an issue like this, my usual approach is to follow upstream for the fix and wait a little while before performing the upgrade. And I think I won't be able to upgrade azure-cli this weekend because of that. I'm mentioning this because I'm unsure about the criticality of the msal upgrade for you or your consumer/requirement port maintenance that you are currently working on. Please, let me know if that is a trouble for you. Kind Regards.
Hi Danilo, Thank you for the work you are doing. I think the issue you are seeing is with py-cryptography being too old. I am following bug 254853 closely, but this needs to go in so that it will support the newer version of py-cryptography when it lands. If you apply the patch to update py-cryptography it should work. Regards, Brad Davis
Created attachment 243553 [details] patch
(In reply to Brad Davis from comment #3) Great that you mentioned that. I re-tested this upgrade on FreeBSD 13, and it's working fine. However, on 14-CURRENT, the current version still doesn't work and shows the same error I mentioned above during the upgrade test. In light of this, I'll proceed here with your first patch. Thanks.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=67b557ff9a5ef78e64226f2176f856fa59070566 commit 67b557ff9a5ef78e64226f2176f856fa59070566 Author: Brad Davis <brd@FreeBSD.org> AuthorDate: 2023-07-21 23:46:43 +0000 Commit: Danilo G. Baio <dbaio@FreeBSD.org> CommitDate: 2023-07-23 00:27:39 +0000 devel/py-msal: Update to 1.22.0 PR: 272640 Co-authored-by: Danilo G. Baio <dbaio@FreeBSD.org> devel/py-msal/Makefile | 3 ++- devel/py-msal/distinfo | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-)
Thank you, Brad.
Thanks Danilo!