Bug 272702 - security/nflib: Remove NATIVE option
Summary: security/nflib: Remove NATIVE option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-24 21:54 UTC by Daniel Engberg
Modified: 2023-08-07 07:07 UTC (History)
0 users

See Also:
yuri: maintainer-feedback-

Attachments
Patch for nflib (3.07 KB, patch)
2023-07-24 21:54 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-07-24 21:54:53 UTC 
Created attachment 243597 [details]
Patch for nflib

Rely on CPUTYPE and what the compiler defines

Compile and runtime tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist make test)
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-08-07 06:23:04 UTC 
I don't think that this patch is correct.
NFL_OPTIMIZED should be enabled in sync with WITH_DEBUG=yes. Disabling it isn't right.

I will commit an altered patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-08-07 06:45:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ce1070f1121f0d062dcf393bdc42f39d15438e13

commit ce1070f1121f0d062dcf393bdc42f39d15438e13
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-08-07 06:42:51 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-08-07 06:44:53 +0000

    security/nflib: Remove NATIVE option

    Let CPUTYPE handle native optimizations.

    PR:             272702
    Reported by:    diizzy@

 security/nflib/Makefile                             |  6 +-----
 security/nflib/files/patch-CMakeCompilers.txt (new) | 11 +++++++++++
 security/nflib/files/patch-CMakeLists.txt           | 11 ++++++++++-
 3 files changed, 22 insertions(+), 6 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-08-07 07:01:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=950dfcdb8daf2917b474950a8d71b1dc722fbe48

commit 950dfcdb8daf2917b474950a8d71b1dc722fbe48
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-08-07 07:00:40 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-08-07 07:00:40 +0000

    security/nflib: Turn on inner optimization option when no WITH_DEBUG is defined

    PR:             272702

 security/nflib/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-08-07 07:07:59 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dbe826b8640bbd7dc2952f796e7d4b8be691c37a

commit dbe826b8640bbd7dc2952f796e7d4b8be691c37a
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-08-07 07:06:41 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-08-07 07:07:15 +0000

    security/nflib: Improve handling of SIMD instructions

    PR:             272702

 security/nflib/Makefile                            |  2 +-
 .../nflib/files/patch-include_nfl_arch.hpp (new)   | 19 ++++++++++++++++++
 .../nflib/files/patch-include_nfl_ops.hpp (new)    | 23 ++++++++++++++++++++++
 3 files changed, 43 insertions(+), 1 deletion(-)