Bug 272778 - x11/waybar depends on devel/date though devel/hhdate may also be used.
Summary: x11/waybar depends on devel/date though devel/hhdate may also be used.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-28 15:05 UTC by Alexander Chernyavsky
Modified: 2023-08-06 14:53 UTC (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Chernyavsky 2023-07-28 15:05:11 UTC
x11/waybar depends on devel/date which carries the same libraries as devel/hhdate. The two ports, devel/date and devel/hhdate install the same files and so installing both is not possible. 

Proposed solution: make x11/waybar depend on either devel/date or devel/hhdate. Either port comes as a dependency for various packages.
Comment 1 Alexander Chernyavsky 2023-07-28 15:08:03 UTC
P.S. Also, why do we have two separate packages for the same library?
Comment 2 Jan Beich freebsd_committer freebsd_triage 2023-07-28 15:37:28 UTC
According to https://repology.org/project/howard-hinnant-date/versions downstream "date" is more common but
- Arch, Solus, Void add "chrono-" prefix
- FreeBSD, openSUSE add "hh" prefix
- Homebrew, Nix add "howard-hinnant-" prefix

In ports/ there're only 2 consumers:

$ rg -l :devel/date
x11/waybar/Makefile
$ rg -l :devel/hhdate
graphics/podofo/Makefile
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2023-07-28 16:40:47 UTC
The port devel/hhdate is misnamed because the project is called "date".
Comment 4 Alexander Chernyavsky 2023-07-28 17:44:12 UTC
(In reply to Jan Beich from comment #2)
> In ports/ there're only 2 consumers:

> $ rg -l :devel/date
> x11/waybar/Makefile
> $ rg -l :devel/hhdate
> graphics/podofo/Makefile

I hit the jackpot having to install both.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2023-07-28 18:15:43 UTC
I am ok with removing devel/date and then renaming devel/hhdate into devel/date.

Just ask sunpoet@ to approve the subsequent rename.
Comment 6 Alexander Chernyavsky 2023-07-28 19:36:46 UTC
(In reply to Yuri Victorovich from comment #5)

@sunpoet, are you okay with renaming devel/hhdate into devel/date?
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-08-01 12:54:47 UTC
(In reply to Yuri Victorovich from comment #5)
(In reply to Alexander Chernyavsky from comment #6)

I'm OK with this change. Thanks!
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-08-05 12:19:00 UTC
Will remove devel/date and rename devel/hhdate to devel/date as decided.
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-08-06 12:44:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5ef69a723be1535e09ef85f8a25bb1c7e2fb549b

commit 5ef69a723be1535e09ef85f8a25bb1c7e2fb549b
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-08-05 12:17:42 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-06 12:42:47 +0000

    devel/hhdate: move to devel/date

    Now that the old devel/date has been removed, use the old port name
    for the version we decided to keep.

    PR:             272778
    Reported by:    Alexander Chernyavsky <nickp102@gmail.com>
    Approved by:    sunpoet

 MOVED                                         | 2 +-
 devel/Makefile                                | 2 +-
 devel/{hhdate => date}/Makefile               | 2 +-
 devel/{hhdate => date}/distinfo               | 0
 devel/{hhdate => date}/files/test-minimal.cpp | 0
 devel/{hhdate => date}/pkg-descr              | 0
 devel/{hhdate => date}/pkg-plist              | 0
 graphics/podofo/Makefile                      | 2 +-
 x11/waybar/Makefile                           | 2 +-
 9 files changed, 5 insertions(+), 5 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-08-06 12:44:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=01258aa86c3aa538c12a03adf8dd08861087505c

commit 01258aa86c3aa538c12a03adf8dd08861087505c
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-08-05 12:13:13 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-06 12:42:47 +0000

    devel/date: remove port

    This port has an older version of the library shipped in devel/hhdate.
    Remove it in preparation of replacement with devel/hhdate.

    PR:             272778
    Reported by:    Alexander Chernyavsky <nickp102@gmail.com>
    Approved by:    yuri

 MOVED                       |  1 +
 devel/Makefile              |  1 -
 devel/date/Makefile (gone)  | 42 ------------------------------------------
 devel/date/distinfo (gone)  |  3 ---
 devel/date/pkg-descr (gone) | 20 --------------------
 x11/waybar/Makefile         |  2 +-
 6 files changed, 2 insertions(+), 67 deletions(-)
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2023-08-06 12:50:49 UTC
All done I hope!
Comment 12 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-08-06 14:26:00 UTC
(In reply to Robert Clausecker from comment #11)

Thanks!
Please also bump PORTREVISION of graphics/podofo for the dependency change (from devel/hhdate to devel/date).
Comment 13 commit-hook freebsd_committer freebsd_triage 2023-08-06 14:53:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=75188ea4115b09eaf3373971ecd4cbd7d978209f

commit 75188ea4115b09eaf3373971ecd4cbd7d978209f
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-08-06 14:52:57 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-06 14:53:44 +0000

    graphics/podofo: bump portrevision following devel/date dependency move

    Reported by:    sunpoet
    Approved by:    sunpoet
    PR:             272778

 graphics/podofo/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)