Bug 272797 - www/ungoogled-chromium: fails to build if CODECS off "proprietary_codecs required for enable_mse_mpeg2ts_stream_parser"
Summary: www/ungoogled-chromium: fails to build if CODECS off "proprietary_codecs requ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-chromium (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-29 14:18 UTC by Vladimir Druzenko
Modified: 2023-07-31 20:27 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (chromium)
vvd: merge-quarterly?


Attachments
Fix build if CODECS off (895 bytes, patch)
2023-07-29 14:18 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2023-07-29 14:18:36 UTC
Created attachment 243690 [details]
Fix build if CODECS off

Build fails if CODECS option off with error:
cd /wrkdirs/usr/ports/www/ungoogled-chromium/work/chromium-115.0.5790.110 && /usr/bin/env MAKE=gmake ac_cv_path_PERL=/usr/local/bin/perl ac_cv_path_PERL_PATH=/usr/local/bin/perl  PERL_USE_UNSAFE_INC=1 PKG_CONFIG=pkgconf PYTHON="/usr/local/bin/python3.9" QT_SELECT=qt5 QMAKEMODULES="/wrkdirs/usr/ports/www/ungoogled-chromium/work/chromium-115.0.5790.110/mkspecs/modules:/usr/local/lib/qt5/mkspecs/modules" XDG_DATA_HOME=/wrkdirs/usr/ports/www/ungoogled-chromium/work  XDG_CONFIG_HOME=/wrkdirs/usr/ports/www/ungoogled-chromium/work  XDG_CACHE_HOME=/wrkdirs/usr/ports/www/ungoogled-chromium/work/.cache  HOME=/wrkdirs/usr/ports/www/ungoogled-chromium/work TMPDIR="/tmp" PATH=/wrkdirs/usr/ports/www/ungoogled-chromium/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/nonexistent/bin PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/www/ungoogled-chromium/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig SHELL=/bin/sh CONFIG_SHELL=/bin/sh CMAKE_PREFIX_PATH="/usr/local" LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 ./out/Release/gn  gen --args='fatal_linker_warnings=false  icu_use_data_file=false  is_clang=true  optimize_webui=true  toolkit_views=true  use_allocator_shim=false  use_aura=true  use_custom_libcxx=false  use_gnome_keyring=false  use_lld=true  use_partition_alloc=true  use_partition_alloc_as_malloc=false  use_sysroot=false  use_system_freetype=false  use_system_harfbuzz=true  use_system_libffi=true  use_system_libjpeg=true  use_udev=false  extra_cxxflags="-O2 -pipe -march=nehalem -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include "  extra_ldflags=" -fstack-protector-strong -L/usr/local/lib "  ffmpeg_branding="Chromium" build_with_tflite_lib=false  chrome_pgo_phase=0  clang_use_chrome_plugins=false  disable_fieldtrial_testing_config=true  enable_backup_ref_ptr_support=false  enable_hangout_services_extension=false  enable_mdns=false  enable_mse_mpeg2ts_stream_parser=true  enable_nacl=false  enable_reading_list=false  enable_remoting=false  enable_reporting=false  enable_rust=false  enable_service_discovery=false  exclude_unwind_tables=true  google_api_key=""  google_default_client_id=""  google_default_client_secret=""  safe_browsing_mode=0  treat_warnings_as_errors=false  use_official_google_api_keys=false  use_unofficial_version_number=false use_alsa=false proprietary_codecs=false use_cups=false blink_symbol_level=0 is_debug=false is_official_build=true symbol_level=0 use_kerberos=false use_thin_lto=false use_pulseaudio=false use_sndio=false' out/Release
ERROR at //media/media_options.gni:151:1: Assertion failed.
assert(!enable_mse_mpeg2ts_stream_parser || proprietary_codecs,
^-----
proprietary_codecs required for enable_mse_mpeg2ts_stream_parser
See //BUILD.gn:28:1: whence it was imported.
import("//media/media_options.gni")
^---------------------------------

Fix is trivial - patch attached.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-07-31 10:25:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d94c05b56989f9fea2c2efeacc4714e33aded53e

commit d94c05b56989f9fea2c2efeacc4714e33aded53e
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2023-07-31 10:22:15 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2023-07-31 10:24:01 +0000

    www/ungoogled-chromium: do not force enable_mse_mpeg2ts_stream_parser to true

    enable_mse_mpeg2ts_stream_parser cannot be forced to true in case
    proprietary codecs are not enabled

    PR:     272797

 www/ungoogled-chromium/Makefile | 1 -
 1 file changed, 1 deletion(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-07-31 10:25:03 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=381b26e540fed487c4391d6f323b8ca275e3cb7e

commit 381b26e540fed487c4391d6f323b8ca275e3cb7e
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2023-07-31 10:22:15 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2023-07-31 10:24:18 +0000

    www/ungoogled-chromium: do not force enable_mse_mpeg2ts_stream_parser to true

    enable_mse_mpeg2ts_stream_parser cannot be forced to true in case
    proprietary codecs are not enabled

    PR:     272797
    (cherry picked from commit d94c05b56989f9fea2c2efeacc4714e33aded53e)

 www/ungoogled-chromium/Makefile | 1 -
 1 file changed, 1 deletion(-)
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2023-07-31 11:43:39 UTC
But if CODECS is enabled, then enable_mse_mpeg2ts_stream_parser will be enabled too?
Comment 4 Robert Nagy freebsd_committer freebsd_triage 2023-07-31 16:18:29 UTC
(In reply to Vladimir Druzenko from comment #3)

Yes, this is handled in here:

https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/media/media_options.gni#136
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2023-07-31 20:27:30 UTC
(In reply to Robert Nagy from comment #4)
Thanks!