Bug 272804 - print/hplip fails to build on 14-CURRENT
Summary: print/hplip fails to build on 14-CURRENT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-30 01:05 UTC by rkoberman
Modified: 2023-08-17 08:05 UTC (History)
1 user (show)

See Also:
tijl: maintainer-feedback+

Attachments
patch to fix fax/filters/cdmfax/jetlib.cpp with llvm16 (to apply with git am) (1.95 KB, patch)
2023-08-01 06:17 UTC, Oleg Sidorkin 		osidorkin: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rkoberman 2023-07-30 01:05:42 UTC 
Updating hplip-3.23.5 ti 3.23.5_1 fails with repeated "error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]" while buiding fax/filters/cdmfax/jetlib.cpp:7572:5

Des this port require C++14?
Comment 1 Oleg Sidorkin 2023-08-01 06:17:57 UTC 
Created attachment 243761 [details]
patch to fix fax/filters/cdmfax/jetlib.cpp with llvm16 (to apply with git am)

After LLVM16 had been MFC'ed, this problem appeared on FreeBSD 13.2 also.
Here's the simple patch  that works for me: make 2 strings const char* and remove register keywords.
Comment 2 rkoberman 2023-08-01 23:58:21 UTC 
I confirm that this allows it compile and can't imagine that it breaks anything, but I don't have any device that would run this code.

Thanks!
Comment 3 Oleg Sidorkin 2023-08-15 06:13:34 UTC 
Maintainer timeout?
Comment 4 Tijl Coosemans freebsd_committer freebsd_triage 2023-08-15 08:15:36 UTC 
Sorry, just forgot about this, committed in ports f97941e2c029.
Comment 5 rkoberman 2023-08-16 20:22:34 UTC 
Patch fails to apply all three hunks. I can't see any difference in the manual diff I made (not a git diff) and the one committed, but I see:
===>  Applying FreeBSD patches for hplip-3.23.5_1 from /usr/ports/print/hplip/files
3 out of 3 hunks failed--saving rejects to fax/filters/cdmfax/jetlib.cpp.rej
===>  FAILED Applying FreeBSD patch-fax_filters_cdmfax_jetlib.cpp
===> Cleanly applied FreeBSD patch(es)  patch-FindPPD.cpp patch-Makefile.in patch-base_g.py patch-base_os__utils.py patch-base_queues.py patch-base_utils.py patch-base_validation.py patch-check.py patch-common_utils.c patch-configure patch-doc_index.html patch-doc_troubleshooting.html patch-fax_backend_hpfax.py
===> FAILED to apply cleanly FreeBSD patch(es)  patch-fax_filters_cdmfax_jetlib.cpp
*** Error code 1

If I get a chance, I'll do more rigorous testing, but it's still broken.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-08-17 07:38:46 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7753f124339fd7c52cddd7afd37c15b1aecf9cc9

commit 7753f124339fd7c52cddd7afd37c15b1aecf9cc9
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2023-08-17 07:24:16 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2023-08-17 07:32:01 +0000

    print/hplip: Fix patch from f97941e2c029

    by applying dos2unix first.

    PR:             272804

 print/hplip/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)