Bug 272881 - audio/mumble: support ARCHes other than x86
Summary: audio/mumble: support ARCHes other than x86
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-01 21:31 UTC by Vladimir Druzenko
Modified: 2023-08-28 19:26 UTC (History)
2 users (show)

See Also:


Attachments
patch (3.66 KB, patch)
2023-08-02 06:43 UTC, Piotr Kubaj
no flags Details | Diff
Option OVERLAY_32BIT for 32bit overlay module (6.11 KB, patch)
2023-08-05 15:52 UTC, Vladimir Druzenko
no flags Details | Diff
Option OVERLAY_32BIT for 32bit overlay module v2 (6.18 KB, patch)
2023-08-15 14:44 UTC, Vladimir Druzenko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2023-08-01 21:31:57 UTC
pkg-fallout on aarch64:
Log URL:        https://pkg-status.freebsd.org/ampere3/data/131arm64-default/6dc86af8d738/logs/mumble-1.5.517.log
Build URL:      https://pkg-status.freebsd.org/ampere3/build.html?mastername=131arm64-default&build=6dc86af8d738

-- Looking for sys/cdefs.h
-- Looking for sys/cdefs.h - not found
CMake Error at overlay_gl/CMakeLists.txt:46 (message):
  Can't find the 32bit version of sys/cdefs.h - did you install g++-multilib?
-- Configuring incomplete, errors occurred!
*** Error code 1

Check for sys/cdefs.h is here:
https://github.com/mumble-voip/mumble/blob/v1.5.517/overlay_gl/CMakeLists.txt#L40

Probably it doesn't support overlay on any arm:
https://github.com/mumble-voip/mumble/blob/v1.5.517/CMakeLists.txt#L174

To turn it off move "overlay" from "CMAKE_ON=" to "CMAKE_OFF=".
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2023-08-01 21:34:26 UTC
pkubaj@ working on patch for powerpc64le.
Maybe track all ARCHes in one PR.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-08-01 21:34:42 UTC
Will have a look, thanks.
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2023-08-02 06:43:29 UTC
Created attachment 243789 [details]
patch

Here's a patch I have for powerpc64le. I haven't tested it on other architectures.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-08-04 22:54:02 UTC
(In reply to Piotr Kubaj from comment #3)

Build fails on arm64 FreeBSD 13.2 even with this patch.  This may be because there is no lib32 support on arm64 yet AFAIK.

-- Looking for sys/cdefs.h
-- Looking for sys/cdefs.h - not found
CMake Error at overlay_gl/CMakeLists.txt:46 (message):
  Can't find the 32bit version of sys/cdefs.h - did you install g++-multilib?


-- Configuring incomplete, errors occurred!
*** Error code 1

Stop.
make: stopped in /usr/ports/audio/mumble
build of audio/mumble | mumble-1.5.517 ended at Sat Aug  5 00:52:03 CEST 2023
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-08-05 08:08:21 UTC
Same failure on armv7 with pkubaj@'s patch.
Comment 6 Piotr Kubaj freebsd_committer freebsd_triage 2023-08-05 13:05:40 UTC
I'm currently away from home so can't check on my aarch64 box, but when I'm back (tomorrow), I will update it and check the mumble port there. Note that I use CURRENT because apparently DPAA2 is only supported there.
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2023-08-05 15:52:47 UTC
Created attachment 243872 [details]
Option OVERLAY_32BIT for 32bit overlay module

Try to use this patch as the basis.
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2023-08-15 14:44:04 UTC
Created attachment 244119 [details]
Option OVERLAY_32BIT for 32bit overlay module v2

Updated patch.
Comment 9 Vladimir Druzenko freebsd_committer freebsd_triage 2023-08-23 15:14:18 UTC
Check this patch: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=244298&action=diff
You can add build of the 32bit overlay on other ARCHes same as done for amd64.
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-08-28 18:56:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=08c1696fb18eac0edbbdc884b5c346e9699c27cc

commit 08c1696fb18eac0edbbdc884b5c346e9699c27cc
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2023-08-28 18:41:13 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2023-08-28 18:41:13 +0000

    audio/mumble: switch from USE_GITHUB to pre-rolled release and fix build on ARCHes other than x86

    1. Switch from USE_GITHUB to pre-rolled release.
    2. Use CMake to install the files instead of using custom do-install target.
    3. Unbundle devel/microsoft-gsl.
    4. Fix build and keep possibility to build 32bit overlay on other ARCHes than x86.
    5. "Pet portclippy".

    Ideas, patches and testing: fuz, jhale, pkubaj.

    PR:                     273203 272881
    Approved by:            tcberner
    Differential Revision:  https://reviews.freebsd.org/D41604
    MFH:                    2023Q3

 audio/mumble/Makefile                              | 118 ++++++++-------------
 audio/mumble/distinfo                              |  20 +---
 ...ary__files_run__scripts_mumble-overlay.in (new) |  32 ++++++
 .../files/patch-overlay__gl_CMakeLists.txt (new)   |  16 +++
 audio/mumble/pkg-plist                             |  19 ++--
 5 files changed, 107 insertions(+), 98 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2023-08-28 19:10:43 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3553d5df611e8c79350784060404ae643e9c85ba

commit 3553d5df611e8c79350784060404ae643e9c85ba
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2023-08-28 18:41:13 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2023-08-28 19:09:50 +0000

    audio/mumble: switch from USE_GITHUB to pre-rolled release and fix build on ARCHes other than x86

    1. Switch from USE_GITHUB to pre-rolled release.
    2. Use CMake to install the files instead of using custom do-install target.
    3. Unbundle devel/microsoft-gsl.
    4. Fix build and keep possibility to build 32bit overlay on other ARCHes than x86.
    5. "Pet portclippy".

    Ideas, patches and testing: fuz, jhale, pkubaj.

    PR:                     273203 272881
    Approved by:            tcberner
    Differential Revision:  https://reviews.freebsd.org/D41604
    MFH:                    2023Q3

    (cherry picked from commit 08c1696fb18eac0edbbdc884b5c346e9699c27cc)

 audio/mumble/Makefile                              | 118 ++++++++-------------
 audio/mumble/distinfo                              |  20 +---
 ...ary__files_run__scripts_mumble-overlay.in (new) |  32 ++++++
 .../files/patch-overlay__gl_CMakeLists.txt (new)   |  16 +++
 audio/mumble/pkg-plist                             |  19 ++--
 5 files changed, 107 insertions(+), 98 deletions(-)
Comment 12 Vladimir Druzenko freebsd_committer freebsd_triage 2023-08-28 19:26:48 UTC
After this commit audio/mumble must build fine on other ARCHes, but without 32bit overlay.
If you want to add build 32bit overaly - free to open this issue again and suggest patches.

Thanks!