Bug 272999 - [NEW PORTS] dynamic modules for www/angie
Summary: [NEW PORTS] dynamic modules for www/angie
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-07 14:19 UTC by oleg
Modified: 2023-08-09 13:14 UTC (History)
1 user (show)

See Also:


Attachments
Adding checksums for new distfiles (1.68 KB, patch)
2023-08-07 14:19 UTC, oleg
no flags Details | Diff
www/angie-module-auth-jwt (2.14 KB, patch)
2023-08-07 14:22 UTC, oleg
no flags Details | Diff
www/angie-module-brotli (2.70 KB, patch)
2023-08-07 14:22 UTC, oleg
no flags Details | Diff
www/angie-module-cache-purge (2.10 KB, patch)
2023-08-07 14:23 UTC, oleg
no flags Details | Diff
www/angie-module-image-filter (2.07 KB, patch)
2023-08-07 14:23 UTC, oleg
no flags Details | Diff
www/angie-module-jwt (2.04 KB, patch)
2023-08-07 14:24 UTC, oleg
no flags Details | Diff
www/angie-module-keyval (2.02 KB, patch)
2023-08-07 14:24 UTC, oleg
no flags Details | Diff
www/angie-module-njs (2.29 KB, patch)
2023-08-07 14:24 UTC, oleg
no flags Details | Diff
www/angie-module-perl (3.07 KB, patch)
2023-08-07 14:25 UTC, oleg
no flags Details | Diff
www/angie-module-redis2 (2.04 KB, patch)
2023-08-07 14:25 UTC, oleg
no flags Details | Diff
www/angie-module-xslt (1.93 KB, patch)
2023-08-07 14:25 UTC, oleg
no flags Details | Diff
Correction for www/angie-module-auth-jwt (902 bytes, patch)
2023-08-08 14:04 UTC, oleg
no flags Details | Diff
Correction for www/angie-module-brotli (910 bytes, patch)
2023-08-08 14:04 UTC, oleg
no flags Details | Diff
Correction for www/angie-module-cache-purge (876 bytes, application/mbox)
2023-08-08 14:05 UTC, oleg
no flags Details
Correction for www/angie-module-image-filter (774 bytes, patch)
2023-08-08 14:05 UTC, oleg
no flags Details | Diff
Correction for www/angie-module-jwt (799 bytes, patch)
2023-08-08 14:06 UTC, oleg
no flags Details | Diff
Correction for www/angie-module-keyval (804 bytes, patch)
2023-08-08 14:06 UTC, oleg
no flags Details | Diff
Correction for www/angie-module-njs (1.19 KB, patch)
2023-08-08 14:07 UTC, oleg
no flags Details | Diff
Correction for www/angie-module-redis2 (856 bytes, patch)
2023-08-08 14:07 UTC, oleg
no flags Details | Diff
Correction for www/angie-module-xslt (735 bytes, patch)
2023-08-08 14:08 UTC, oleg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description oleg 2023-08-07 14:19:39 UTC
Created attachment 243927 [details]
Adding checksums for new distfiles

This PR is in continuation of work on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270933

Please note, that 0-distinfo.patch should be applied the very first.
Comment 1 oleg 2023-08-07 14:22:23 UTC
Created attachment 243928 [details]
www/angie-module-auth-jwt
Comment 2 oleg 2023-08-07 14:22:49 UTC
Created attachment 243929 [details]
www/angie-module-brotli
Comment 3 oleg 2023-08-07 14:23:13 UTC
Created attachment 243930 [details]
www/angie-module-cache-purge
Comment 4 oleg 2023-08-07 14:23:36 UTC
Created attachment 243931 [details]
www/angie-module-image-filter
Comment 5 oleg 2023-08-07 14:24:01 UTC
Created attachment 243932 [details]
www/angie-module-jwt
Comment 6 oleg 2023-08-07 14:24:26 UTC
Created attachment 243933 [details]
www/angie-module-keyval
Comment 7 oleg 2023-08-07 14:24:46 UTC
Created attachment 243934 [details]
www/angie-module-njs
Comment 8 oleg 2023-08-07 14:25:08 UTC
Created attachment 243935 [details]
www/angie-module-perl
Comment 9 oleg 2023-08-07 14:25:31 UTC
Created attachment 243936 [details]
www/angie-module-redis2
Comment 10 oleg 2023-08-07 14:25:53 UTC
Created attachment 243937 [details]
www/angie-module-xslt
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2023-08-07 18:17:25 UTC
This would have been so much easier with patches in git-format-patch(1) format...
Comment 12 Robert Clausecker freebsd_committer freebsd_triage 2023-08-07 18:44:46 UTC
Please fix the following portlint issues:

 - pkg-descr should be at least three lines for all ports.
   Also hard-break the lines in pkg-descr to no more than
   80 columns please.
 - also please avoid trailing whitespace in pkg-descr
 - for the future, please remember to hook each port into its
   category Makefile.  I have done it for you this time, but
   it's better if you do it.
 - make sure patch files were generated with make makepatch.
   I have fixed this for you, too.

When you fix these issues, please post patches that apply on top of your patch set so I can easily fix up the commits I have prepared from them.
Comment 13 Robert Clausecker freebsd_committer freebsd_triage 2023-08-07 20:28:18 UTC
www/angie-module-xslt fails during configuration, likely due to a missing library dependency:

checking for libxslt ... not found
checking for libxslt in /usr/local/ ... not found
checking for libxslt in /usr/pkg/ ... not found
checking for libxslt in /opt/local/ ... not found

./configure: error: the HTTP XSLT module requires the libxml2/libxslt
libraries. You can either do not enable the module or install the libraries.

===>  Script "configure" failed unexpectedly.
Comment 14 Robert Clausecker freebsd_committer freebsd_triage 2023-08-07 20:34:34 UTC
sorry, I mean the njs module, not the xslt module.
Comment 15 oleg 2023-08-08 14:04:18 UTC
Created attachment 243960 [details]
Correction for www/angie-module-auth-jwt
Comment 16 oleg 2023-08-08 14:04:57 UTC
Created attachment 243961 [details]
Correction for www/angie-module-brotli
Comment 17 oleg 2023-08-08 14:05:26 UTC
Created attachment 243962 [details]
Correction for www/angie-module-cache-purge
Comment 18 oleg 2023-08-08 14:05:51 UTC
Created attachment 243963 [details]
Correction for www/angie-module-image-filter
Comment 19 oleg 2023-08-08 14:06:19 UTC
Created attachment 243964 [details]
Correction for www/angie-module-jwt
Comment 20 oleg 2023-08-08 14:06:46 UTC
Created attachment 243965 [details]
Correction for www/angie-module-keyval
Comment 21 oleg 2023-08-08 14:07:23 UTC
Created attachment 243966 [details]
Correction for www/angie-module-njs
Comment 22 oleg 2023-08-08 14:07:46 UTC
Created attachment 243967 [details]
Correction for www/angie-module-redis2
Comment 23 oleg 2023-08-08 14:08:11 UTC
Created attachment 243968 [details]
Correction for www/angie-module-xslt
Comment 24 oleg 2023-08-08 14:14:36 UTC
Hi,

Post patches are uploaded, thanks for suggestion about git-format-patch :)

I'm just not sure if we want to assign additional categories to each port.
They always have 'CATEGORIES+= www' implicitly set in the master Makefile.
But if you see any advantages of adding extra ones - please do.
Comment 25 Robert Clausecker freebsd_committer freebsd_triage 2023-08-08 14:20:56 UTC
(In reply to oleg from comment #24)

Thanks.  This looks good.  I think I can commit these with my next batch.

> I'm just not sure if we want to assign additional categories to each port.
> They always have 'CATEGORIES+= www' implicitly set in the master Makefile.
> But if you see any advantages of adding extra ones - please do.

What I mean by "category Makefile" is that the file www/Makefile must have an
entry for each port in the www directory.  I have added these entries for you
this time, but it's much easier to process a patch when this addition is already
in the patch.
Comment 26 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=98173bcdc0a87932e5a5d2b95cf963c918dda82d

commit 98173bcdc0a87932e5a5d2b95cf963c918dda82d
Author:     Oleg A. Mamontov <oleg@mamontov.net>
AuthorDate: 2023-08-07 18:41:50 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:17 +0000

    www/angie-module-perl: Angie Perl dynamic module

    Module is used to implement location and variable handlers in Perl and insert
    Perl calls into SSI.

    PR:             272999

 www/Makefile                                       |  1 +
 www/angie-module-perl/Makefile (new)               | 32 ++++++++++++++++++++++
 .../patch-src_http_modules_perl_Makefile.PL (new)  | 11 ++++++++
 www/angie-module-perl/files/pkg-message.in (new)   | 15 ++++++++++
 www/angie-module-perl/pkg-descr (new)              |  2 ++
 www/angie-module-perl/pkg-plist (new)              |  4 +++
 6 files changed, 65 insertions(+)
Comment 27 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=76e796faaf175ec23e24a98ba1649a1732fa2194

commit 76e796faaf175ec23e24a98ba1649a1732fa2194
Author:     Oleg A. Mamontov <oleg@mamontov.net>
AuthorDate: 2023-08-07 18:43:07 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:17 +0000

    www/angie-module-redis2: Angie redis2 dynamic module

    Module makes Angie talk to a Redis 2.x server in a non-blocking way.

    PR:             272999

 www/Makefile                                       |  1 +
 www/angie-module-redis2/Makefile (new)             | 24 ++++++++++++++++++++++
 www/angie-module-redis2/files/pkg-message.in (new) | 15 ++++++++++++++
 www/angie-module-redis2/pkg-descr (new)            |  3 +++
 www/angie-module-redis2/pkg-plist (new)            |  3 +++
 5 files changed, 46 insertions(+)
Comment 28 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f84b99340c51e3fdda005df1ad331f6a0cb45842

commit f84b99340c51e3fdda005df1ad331f6a0cb45842
Author:     Oleg A. Mamontov <oleg@mamontov.net>
AuthorDate: 2023-08-07 18:44:13 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:18 +0000

    www/angie-module-xslt: Angie XSLT dynamic module

    Module is a filter that transforms XML responses using XSLT stylesheets.

    PR:             272999

 www/Makefile                                     |  1 +
 www/angie-module-xslt/Makefile (new)             | 24 ++++++++++++++++++++++++
 www/angie-module-xslt/files/pkg-message.in (new) | 15 +++++++++++++++
 www/angie-module-xslt/pkg-descr (new)            |  3 +++
 www/angie-module-xslt/pkg-plist (new)            |  2 ++
 5 files changed, 45 insertions(+)
Comment 29 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8b299dec679441240f27cff3577a8a5b60fc6c9a

commit 8b299dec679441240f27cff3577a8a5b60fc6c9a
Author:     Oleg A. Mamontov <oleg@mamontov.net>
AuthorDate: 2023-08-07 18:30:02 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:16 +0000

    www/angie-module-image-filter: Angie image-filter dynamic module

    Module is a filter that transforms images in JPEG, GIF, PNG, and WebP formats.

    PR:             272999

 www/Makefile                                       |  1 +
 www/angie-module-image-filter/Makefile (new)       | 24 ++++++++++++++++++++++
 .../files/pkg-message.in (new)                     | 15 ++++++++++++++
 www/angie-module-image-filter/pkg-descr (new)      |  3 +++
 www/angie-module-image-filter/pkg-plist (new)      |  2 ++
 5 files changed, 45 insertions(+)
Comment 30 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=31122efc5f250eb707758ddd6aab8f858d73fad9

commit 31122efc5f250eb707758ddd6aab8f858d73fad9
Author:     Oleg A. Mamontov <oleg@mamontov.net>
AuthorDate: 2023-08-07 18:34:43 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:16 +0000

    www/angie-module-keyval: Angie keyval dynamic module

    This Angie module creates variables with values
    taken from key-value pairs.

    PR:     272999

 www/Makefile                                       |  1 +
 www/angie-module-keyval/Makefile (new)             | 24 ++++++++++++++++++++++
 www/angie-module-keyval/files/pkg-message.in (new) | 15 ++++++++++++++
 www/angie-module-keyval/pkg-descr (new)            |  3 +++
 www/angie-module-keyval/pkg-plist (new)            |  3 +++
 5 files changed, 46 insertions(+)
Comment 31 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=28f5935e59a9fc08dc7c0abcb6a1161431964464

commit 28f5935e59a9fc08dc7c0abcb6a1161431964464
Author:     Oleg A. Mamontov <oleg@mamontov.net>
AuthorDate: 2023-08-07 18:32:57 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:16 +0000

    www/angie-module-jwt: Angie JWT dynamic module

    Module provides JWT validity check funcionality for Angie.

    PR:             272999

 www/Makefile                                    |  1 +
 www/angie-module-jwt/Makefile (new)             | 27 +++++++++++++++++++++++++
 www/angie-module-jwt/files/pkg-message.in (new) | 15 ++++++++++++++
 www/angie-module-jwt/pkg-descr (new)            |  3 +++
 www/angie-module-jwt/pkg-plist (new)            |  3 +++
 5 files changed, 49 insertions(+)
Comment 32 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e031e6e3a155ae3aa794ed78bf21b125f57bf33d

commit e031e6e3a155ae3aa794ed78bf21b125f57bf33d
Author:     Oleg A. Mamontov <oleg@mamontov.net>
AuthorDate: 2023-08-07 18:28:09 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:16 +0000

    www/angie-module-cache-purge: Angie cache_purge dynamic module

    Module which adds ability to purge content from FastCGI, proxy, SCGI and
    uWSGI caches.

    PR:             272999

 www/Makefile                                       |  1 +
 www/angie-module-cache-purge/Makefile (new)        | 22 ++++++++++++++++++++++
 .../files/pkg-message.in (new)                     | 15 +++++++++++++++
 www/angie-module-cache-purge/pkg-descr (new)       |  3 +++
 www/angie-module-cache-purge/pkg-plist (new)       |  3 +++
 5 files changed, 44 insertions(+)
Comment 33 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0e9787f2f5d748a7e37609278567dd8c7b42035e

commit 0e9787f2f5d748a7e37609278567dd8c7b42035e
Author:     Oleg A. Mamontov <oleg@mamontov.net>
AuthorDate: 2023-08-07 18:37:18 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:17 +0000

    www/angie-module-njs: Angie NJS dynamic module

    Module is a subset of the JavaScript language that allows extending
    Angie functionality.

    PR:             272999

 www/Makefile                                    |  1 +
 www/angie-module-njs/Makefile (new)             | 32 +++++++++++++++++++++++++
 www/angie-module-njs/files/pkg-message.in (new) | 18 ++++++++++++++
 www/angie-module-njs/pkg-descr (new)            |  3 +++
 www/angie-module-njs/pkg-plist (new)            |  6 +++++
 5 files changed, 60 insertions(+)
Comment 34 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=75574aa769a2f27ff844717fa46d2215fd2ac5d3

commit 75574aa769a2f27ff844717fa46d2215fd2ac5d3
Author:     Oleg A. Mamontov <oleg@mamontov.net>
AuthorDate: 2023-08-07 18:19:21 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:15 +0000

    www/angie: add dynamic modules to distinfo

    In preparation to the addition of various dynamic modules, add them
    to www/angie's distinfo.

    PR:             272999

 www/angie/distinfo | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
Comment 35 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=41d2ade1eb634232d92ab60d4c5e0904ddced9db

commit 41d2ade1eb634232d92ab60d4c5e0904ddced9db
Author:     Oleg A. Mamontov <oleg@mamontov.net>
AuthorDate: 2023-08-07 18:24:32 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:15 +0000

    www/angie-module-brotli: Angie Brotli dynamic module

    Module adds Brotli compression support to Angie.
    Brotli is a generic-purpose lossless compression algorithm that compresses
    data using a combination of a modern variant of the LZ77 algorithm, Huffman
    coding and 2nd order context modeling, with a compression ratio comparable
    to the best currently available general-purpose compression methods.

    It is similar in speed with deflate but offers more dense compression.

    PR:             272999

 www/Makefile                                       |  1 +
 www/angie-module-brotli/Makefile (new)             | 28 ++++++++++++++++++++++
 www/angie-module-brotli/files/pkg-message.in (new) | 17 +++++++++++++
 www/angie-module-brotli/pkg-descr (new)            |  5 ++++
 www/angie-module-brotli/pkg-plist (new)            |  6 +++++
 5 files changed, 57 insertions(+)
Comment 36 Robert Clausecker freebsd_committer freebsd_triage 2023-08-09 13:14:39 UTC
Thank you for your contribution.