Bug 273042 - x11-wm/hikari: drop setuid bit from hikari-unlocker
Summary: x11-wm/hikari: drop setuid bit from hikari-unlocker
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-10 09:37 UTC by Jan Beich
Modified: 2023-08-11 13:44 UTC (History)
1 user (show)

See Also:
ashish: maintainer-feedback+

Attachments
v1 (apply via "git am") (2.12 KB, patch)
2023-08-10 09:37 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2023-08-10 09:37:54 UTC 
Created attachment 244001 [details]
v1 (apply via "git am")

Similar to ports 1a6e018f6243 + ports 4f53b9995818.

Disclaimer: Runtime is untested as I don't use Hikari.
Comment 1 Ashish SHUKLA freebsd_committer freebsd_triage 2023-08-11 12:43:12 UTC 
Unfortunately, I could not test this either, as my FreeBSD desktop is not in a working state, and won't be for few months.

So, if you think it's okay, then feel free to commit.

Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-08-11 13:43:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=592d2bec114d2ae04e564c22b6a175773c28ab40

commit 592d2bec114d2ae04e564c22b6a175773c28ab40
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-08-10 09:31:47 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-08-11 13:41:28 +0000

    x11-wm/hikari: drop setuid bit from hikari-unlocker

    PR:             273042
    Approved by:    ashish (maintainer)

 x11-wm/hikari/Makefile                                            | 3 ++-
 x11-wm/hikari/files/patch-etc_pam.d_hikari-unlocker.FreeBSD (new) | 8 ++++++++
 x11-wm/hikari/pkg-plist                                           | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2023-08-11 13:44:06 UTC 
Tested myself: locking and unlocking works fine.