Bug 273074 - x11/i3lock-color: drop setuid bit via unix-selfauth-helper
Summary: x11/i3lock-color: drop setuid bit via unix-selfauth-helper
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-11 14:35 UTC by Jan Beich
Modified: 2023-11-06 17:53 UTC (History)
2 users (show)

See Also:
jbeich: maintainer-feedback-
jbeich: merge-quarterly+

Attachments
v1 (apply via "git am") (1.76 KB, patch)
2023-08-11 14:35 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2023-08-11 14:35:41 UTC 
Created attachment 244028 [details]
v1 (apply via "git am")

Based on ports b9050914a875 + bug 273073. Drop pam_helper which has similar purpose but wasn't actually hooked in i3lock-color unlike in xfce4-screensaver.

Disclaimer: Runtime untested as I don't use this port.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-14 11:45:17 UTC 
^Triage: reporter is committer, assign accordingly.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-06 17:50:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=43a873b0bccbeadef7f745f01ac7add5d365b59d

commit 43a873b0bccbeadef7f745f01ac7add5d365b59d
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-08-11 14:23:21 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-11-06 17:49:23 +0000

    x11/i3lock-color: drop setuid bit via unix-selfauth-helper

    pam_helper was supposed to avoid setuid bit but wasn't actually hooked.

    PR:             273074
    Approved by:    maintainer timeout (3 months)

 x11/i3lock-color/Makefile | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-06 17:51:45 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1d96c7ebef903ee680ecd9232013c03826a658cc

commit 1d96c7ebef903ee680ecd9232013c03826a658cc
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-08-11 14:23:21 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-11-06 17:50:40 +0000

    x11/i3lock-color: drop setuid bit via unix-selfauth-helper

    pam_helper was supposed to avoid setuid bit but wasn't actually hooked.

    PR:             273074
    Approved by:    maintainer timeout (3 months)

    (cherry picked from commit 43a873b0bccbeadef7f745f01ac7add5d365b59d)

 x11/i3lock-color/Makefile | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)