Bug 273104 - textproc/R-cran-htmltools: update to 0.5.6
Summary: textproc/R-cran-htmltools: update to 0.5.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://cran.r-project.org/web/packag...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-13 13:29 UTC by Zsolt Udvari
Modified: 2023-08-19 12:51 UTC (History)
1 user (show)

See Also:

Attachments
patch (889 bytes, patch)
2023-08-13 13:29 UTC, Zsolt Udvari 		uzsolt: maintainer-approval+
Details | Diff
PORTVERSION -> DISTVERSION (889 bytes, patch)
2023-08-19 12:28 UTC, Zsolt Udvari 		uzsolt: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari freebsd_committer freebsd_triage 2023-08-13 13:29:20 UTC 
Created attachment 244053 [details]
patch

Simple update to 0.5.6
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-08-19 12:08:22 UTC 
Sugestions:

- Switch to DISTVERSION as described in porter's handbook
- Add test dependencies to get results from `make test`:

+TEST_DEPENDS=  R-cran-testthat>0:devel/R-cran-testthat \
+               R-cran-markdown>0:textproc/R-cran-markdown

I'm new to R packages, besides `make test` is there a simple way to test package?

Thanks
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2023-08-19 12:28:22 UTC 
Created attachment 244211 [details]
PORTVERSION -> DISTVERSION
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2023-08-19 12:30:57 UTC 
(In reply to Nuno Teixeira from comment #1)
These tests are part of TTD (https://en.wikipedia.org/wiki/Test-driven_development). I think shouldn't add it into ports because it tests only the source code not the compiled package.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2023-08-19 12:46:14 UTC 
(In reply to Zsolt Udvari from comment #3)

I've found that tests are usefull sometimes like in security/R-cran-openssl that exposed a possible bug with base openssl3 from 14 current:

security/R-cran-openssl:
Test fails with OpenSSL3: https://github.com/jeroen/openssl/issues/119
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-08-19 12:50:40 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7e33c2050532f45ae230b06057e78855a0cc690f

commit 7e33c2050532f45ae230b06057e78855a0cc690f
Author:     Zsolt Udvari <uzsolt@uzsolt.hu>
AuthorDate: 2023-08-19 12:47:58 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-08-19 12:49:13 +0000

    textproc/R-cran-htmltools: Update to 0.5.6

    - Switch to DISTVERSION

    ChangeLog: https://cran.r-project.org/web/packages/htmltools/news/news.html

    PR:             273104

 textproc/R-cran-htmltools/Makefile | 4 ++--
 textproc/R-cran-htmltools/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2023-08-19 12:51:06 UTC 
Committed, thanks!