Bug 273243 - devel/valgrind: do not strip binaries
Summary: devel/valgrind: do not strip binaries
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-20 11:48 UTC by Paul Floyd
Modified: 2023-08-22 14:17 UTC (History)
2 users (show)

See Also:

Attachments
Set STRIP to empty and add comment (854 bytes, patch)
2023-08-20 11:48 UTC, Paul Floyd 		pjfloyd: maintainer-approval+
Details | Diff
Patch for valgrind-devel (882 bytes, patch)
2023-08-21 19:08 UTC, Paul Floyd 		pjfloyd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Floyd 2023-08-20 11:48:03 UTC 
Created attachment 244224 [details]
Set STRIP to empty and add comment

Valgrind binaries should not be stripped (at least, not the preload shared libs).

I'll look at strippng the non-preload binaries in post one day.

This will also need applying to devel/valgrind-devel
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-21 06:46:09 UTC 
^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.

Can you provide the patch for devel/valgrind-devel?

Thanks!
Comment 2 Paul Floyd 2023-08-21 07:34:00 UTC 
I'll add a valgrind-devel patch tonight.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-21 17:49:37 UTC 
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-08-21 17:50:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9318c43722de21851f11d4b66c6dd9f3b3ce07e9

commit 9318c43722de21851f11d4b66c6dd9f3b3ce07e9
Author:     Paul Floyd <pjfloyd@wanadoo.fr>
AuthorDate: 2023-08-21 06:46:22 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-08-21 17:49:20 +0000

    devel/valgrind: do not strip binaries

    Valgrind binaries should not be stripped (at least, not the preload shared
    libs).

    PR:             273243
    Reported by:    pjfloyd@wanadoo.fr (maintainer)

 devel/valgrind/Makefile | 9 +++++++++
 1 file changed, 9 insertions(+)
Comment 5 Paul Floyd 2023-08-21 19:08:29 UTC 
Created attachment 244260 [details]
Patch for valgrind-devel

I'll reuse the same bugzilla item for valgrind-devel
Comment 6 Paul Floyd 2023-08-21 19:10:08 UTC 
Reopened with patch for valgrind-devel
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-08-22 14:16:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ec06aff4d8821e97187ed86918f0225ad59661d4

commit ec06aff4d8821e97187ed86918f0225ad59661d4
Author:     Paul Floyd <pjfloyd@wanadoo.fr>
AuthorDate: 2023-08-22 07:05:46 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-08-22 14:15:36 +0000

    devel/valgrind-devel: do not strip binaries

    Valgrind binaries should not be stripped (at least, not the preload shared
    libs).

    PR:             273243
    Reported by:    pjfloyd@wanadoo.fr (maintainer)

 devel/valgrind-devel/Makefile | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-22 14:17:16 UTC 
Committed,

Thanks!