Bug 273482 - lang/nim and devel/nimble: Fix pkg-plist and get nimble working
Summary: lang/nim and devel/nimble: Fix pkg-plist and get nimble working
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-31 16:16 UTC by Neal Nelson
Modified: 2023-09-10 16:45 UTC (History)
2 users (show)

See Also:


Attachments
Git diff of changes. (31.81 KB, patch)
2023-08-31 16:16 UTC, Neal Nelson
ports: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Neal Nelson 2023-08-31 16:16:48 UTC
Created attachment 244530 [details]
Git diff of changes.

- Fix problems with optional parts of the pkg-plist of lang/nim.
- Install an extra set of libraries needed by devel/nimble in order to build.
- Fix devel/nimble to find lang/nim in it's new home.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-09-06 02:26:14 UTC
> +BUILD_DEPENDS=	${PREFIX}/nim/bin/nim:lang/nim
> +RUN_DEPENDS=	${PREFIX}/nim/bin/nim:lang/nim

This should be ${LOCALBASE}, surely?  Same with the other places.
Comment 2 Neal Nelson 2023-09-06 06:39:02 UTC
(In reply to Robert Clausecker from comment #1)

You're more than likely correct. It's not clear from the porters manual which one should be used in this situation.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-09-06 11:27:24 UTC
(In reply to Neal Nelson from comment #2)

Your call as the maintainer.  Ports can be installed into prefixes different from their dependencies, so unless there is a compelling reason not to, LOCALBASE should be used to refer to dependencies and PREFIX for the installation path of the port itself.
Comment 4 Neal Nelson 2023-09-07 07:11:40 UTC
If LOCALBASE is the standard, then of course it should be that.

It's altogether unfortunate that lang/nim has to be installed in a non-standard location, but I just couldn't get the module resolution working with the way it was. I've been fighting this since I first wrote the port, but it has finally beaten me with this latest version.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-09-07 13:52:46 UTC
I see.  Yeah, that is kind of annoying.
I'll go ahead and fix the LOCALBASE thing on commit.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-09-10 16:14:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9fd4b3987423a3fb7a0215c821a5764b43ce81a0

commit 9fd4b3987423a3fb7a0215c821a5764b43ce81a0
Author:     Neal Nelson <ports@nicandneal.net>
AuthorDate: 2023-09-07 13:50:52 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-09-10 16:13:04 +0000

    lang/nim: fix plist

     - Fix problems with optional parts of the pkg-plist of lang/nim.
     - Install an extra set of libraries needed by devel/nimble in order to build.

    PR:             273482

 lang/nim/Makefile  |   2 +
 lang/nim/pkg-plist | 891 +++++++++++++++++++++++++++--------------------------
 2 files changed, 455 insertions(+), 438 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-09-10 16:15:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f0da8a9cde456193a4ed5e322eb957632b7f3c3d

commit f0da8a9cde456193a4ed5e322eb957632b7f3c3d
Author:     Neal Nelson <ports@nicandneal.net>
AuthorDate: 2023-09-07 13:51:32 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-09-10 16:13:04 +0000

    devel/nimble: find lang/nim in its new home

    PR:             273482

 devel/nimble/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-09-10 16:45:17 UTC
Thank you for your contribution.