Created attachment 244626 [details] patch adding www/py-offpunk Add port of the offpunk browser
Could you please rectify the QA complains reported by portlint and portclippy? Furthermore, the port subdir and PORTNAME are different. These should be the same (most likely www/offpunk in this particular case).
Created attachment 245406 [details] Updated patch For the new patch I fixed the portlint complaints (I really don't know how I missed such blatant mistakes in the first place...) and changed the port directory as suggested. The remaining complaints by portclippy concern only the ordering of the port options. There I deliberately chose a functional grouping over the purely alphanumeric sorting portclippy suggests. That's just a personal preference and one I'm not too hung up on, so I'll happily change that as well if the port won't get committed otherwise.
Thanks - that's already looking much better! Did you do a runtime test on this? I only tried with the interactive mode of poudriere-testport: \Traceback (most recent call last): File "/usr/local/bin/offpunk", line 5, in <module> from offpunk import main File "/usr/local/lib/python3.9/site-packages/offpunk.py", line 39, in <module> import sqlite3 File "/usr/local/lib/python3.9/sqlite3/__init__.py", line 57, in <module> from sqlite3.dbapi2 import * File "/usr/local/lib/python3.9/sqlite3/dbapi2.py", line 27, in <module> from _sqlite3 import * ModuleNotFoundError: No module named '_sqlite3' Any chance that this is missing a dependency?
Also a question regarding the BOTH option: Is there a particular reason why the CHAFA and the TIMG option can not simply be non-mutually exclusive essentially dropping the need for the BOTH option?
(In reply to Joel Bodenmann from comment #3) I did in fact test the program, however only on a "normal" system that has py-sqlite3 installed as a dependency for other packages. This meant that I didn't run into this problem. (Mainly this is a consequence of separating out core modules from the main python package in FreeBSD which many Linux-only developers seem unaware of.) As to the dependency options, the upstream project page has this to say: - Chafa allows to display pictures in your console. Install it and browse to an HTML page with picture to see the magic. - Timg is a slower alternative to chafa for inline images. But it has better rendering when displaying only the image. Install both to get the best of both world but if you need to choose one, choose Chafa. Because of this I set up the options to allow for the different combinations. Having re-read this (and the surrounding context) again, I tend towards either adding both as regular dependencies, or unconditionally depending on chafa with timg being optional.
Created attachment 245413 [details] Patch with streamlined dependencies
Could you update the attached patch to contain everything? It seems like the currently non-obsolete attachment is the diff to your original diff. Regarding the options: I might be misunderstanding something here, but why not just have both the CHAFA option and the TIMG option as separate options which can be enabled/disabled individually like you had it originally but simply dropping the BOTH option? This way a user can choose CHAFA or TIMG or both (by just allowing to enable both). I'm mainly questioning why the option BOTH exists. If a user wants to have both, they can just enable the CHAFA and the TIMG options at the same time.
Created attachment 245418 [details] patch adding www/offpunk
(In reply to Joel Bodenmann from comment #7) I don't think you are misunderstanding anything. I suspect I was just overcomplicating things when first creating the port. The new patch should be okay now. Thanks for your patience.
I started investigating this myself but I think it makes more sense to throw this back your direction: Given that you have USE_PYTHON=pep517, are ${PY_SETUPTOOLS} and py-wheel really required in BUILD_DEPENDS?
Submitter, any news on this?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=db51a0e68e0021198ae21c1c7de9b5b03d346108 commit db51a0e68e0021198ae21c1c7de9b5b03d346108 Author: Martin Neubauer <m.ne@gmx.net> AuthorDate: 2023-10-04 11:18:20 +0000 Commit: Joel Bodenmann <jbo@FreeBSD.org> CommitDate: 2023-10-30 14:14:50 +0000 www/offpunk: Add new port Offline-first gemini/web/gopher/rss reader and browser. PR: 273554 Approved by: zirias (mentor) Differential Revision: https://reviews.freebsd.org/D42071 www/Makefile | 1 + www/offpunk/Makefile (new) | 42 ++++++++++++++++++++++++++++++++++++++++++ www/offpunk/distinfo (new) | 3 +++ www/offpunk/pkg-descr (new) | 5 +++++ 4 files changed, 51 insertions(+)
Committed - thanks! :)