Bug 273570 - devel/capstone4: fix permissions on bin/cstool
Summary: devel/capstone4: fix permissions on bin/cstool
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-04 19:24 UTC by John Hein
Modified: 2023-09-24 10:46 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (bofh)


Attachments
[patch] fix bin/cstool permissions (1.58 KB, patch)
2023-09-04 19:24 UTC, John Hein
no flags Details | Diff
[patch] fix bin/cstool permissions for devel/capstone4 (809 bytes, patch)
2023-09-11 03:23 UTC, John Hein
jcfyecrayz: maintainer-approval? (oleksii.tsai)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2023-09-04 19:24:43 UTC
Created attachment 244638 [details]
[patch] fix bin/cstool permissions

In the devel/capstone port (and devel/capstone4) bin/cstool is installed with 0644 perissions instead of 0755.

/usr/local/bin/cstool: Permission denied.

The attached patch fixes it (also includes the same fix for devel/capstone4 - that MAINTAINER also CC'd).  This includes a PORTREVISION bump due to the change to the package.

I will submit a patch upstream also.
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-09-05 04:43:36 UTC
As these two ports are maintained by two different persons you should submit another bug for capstone4 for maintainer-approval. On other hand I will commit the fix on my next batch of commits.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-09-05 04:57:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b242d6d26f2b3820c9fad44e5f98133c0d3c7b42

commit b242d6d26f2b3820c9fad44e5f98133c0d3c7b42
Author:     John Hein <jcfyecrayz@liamekaens.com>
AuthorDate: 2023-09-05 04:45:14 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2023-09-05 04:56:13 +0000

    devel/capstone: Fix runtime permissions

    bin/cstool is installed with 0644 perissions instead of 0755 which gives
    permission denied error. This patch fixes this.

    PR:             273570

 devel/capstone/Makefile                   |  1 +
 devel/capstone/files/patch-Makefile (new) | 11 +++++++++++
 2 files changed, 12 insertions(+)
Comment 3 John Hein 2023-09-11 03:14:53 UTC
devel/capstone is fixed - change title to devel/capstone4
Comment 4 John Hein 2023-09-11 03:23:15 UTC
Created attachment 244764 [details]
[patch] fix bin/cstool permissions for devel/capstone4

devel/capstone is fixed - update patch for just devel/capstone4
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-09-24 10:41:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5cc34cf266556ddeed567f809bc953d12f79c7f3

commit 5cc34cf266556ddeed567f809bc953d12f79c7f3
Author:     John Hein <jcfyecrayz@liamekaens.com>
AuthorDate: 2023-09-24 10:37:50 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2023-09-24 10:40:23 +0000

    devel/capstone: Fix runtime permissions

    bin/cstool is installed with 0644 perissions instead of 0755 which gives
    permission denied error. This patch fixes this.

    PR:             273570
    Approved by:    maintainer-timeout

 devel/capstone4/Makefile                   |  1 +
 devel/capstone4/files/patch-Makefile (new) | 11 +++++++++++
 2 files changed, 12 insertions(+)