Bug 273738 - accessibility/at-spi2-core: update to 2.48.4
Summary: accessibility/at-spi2-core: update to 2.48.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL: https://gitlab.gnome.org/GNOME/at-spi...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-12 09:24 UTC by Olivier Duchateau
Modified: 2023-09-23 14:00 UTC (History)
1 user (show)

See Also:

Attachments
Patch to update accessibility/at-spi2-core (3.55 KB, patch)
2023-09-12 09:24 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2023-09-12 09:24:35 UTC 
Created attachment 244790 [details]
Patch to update accessibility/at-spi2-core

Update to 2.48.4
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-09-23 09:58:12 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eefe94d7f92d5372a47bbba500f4246d6235a448

commit eefe94d7f92d5372a47bbba500f4246d6235a448
Author:     Olivier Duchateau <duchateau.olivier@gmail.com>
AuthorDate: 2023-09-12 09:24:35 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-09-23 09:57:31 +0000

    accessibility/at-spi2-core: update to 2.48.4

    - Adjust LICENSE to "or (at your option) any later version" clause
    - Replace systemd hack with a patch that can be upstreamed

    PR:             273738

 accessibility/at-spi2-core/Makefile                          |  9 ++++-----
 accessibility/at-spi2-core/distinfo                          |  6 +++---
 accessibility/at-spi2-core/files/patch-bus_meson.build (new) | 10 ++++++++++
 accessibility/at-spi2-core/pkg-plist                         |  3 ++-
 4 files changed, 19 insertions(+), 9 deletions(-)
Comment 2 Jan Beich freebsd_committer freebsd_triage 2023-09-23 10:08:52 UTC 
Thanks. Landed. I've reverted USE_GNOME=libxml2 change per stage-qa "Warning: you might not need LIB_DEPENDS on libxml2.so"

Note, unrelated changes (license, systemd, libxml2) and missing rationale (commit message) made review for a trivial update unnecessarily complicated. For one, I forgot to document upstream changes (bugzilla "URL" -> "Changes" commit message).
Comment 3 Anton Saietskii 2023-09-23 12:18:18 UTC 
(In reply to Jan Beich from comment #2)

> I've reverted USE_GNOME=libxml2
Looks like this breaks build. See PR #274045.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2023-09-23 13:41:32 UTC 
(In reply to Anton Saietskii from comment #3)
According to "git diff <old>..<new> **/meson.build" upstream didn't touch libxml stuff. From maintenance POV any change to the statu quo requires rationale (for commit message), not just "fixes build" (vs. "builds fine here") or similar cargo cult.
Comment 5 Anton Saietskii 2023-09-23 14:00:38 UTC 
(In reply to Jan Beich from comment #4)

Jan, few points here:

1. libxml2 was pulled by libxkbcommon previously, and after it's dep removal build started to fail.
2. I'm not a maintainer of at-spi2-core, so I just trust its configure script, which clearly says "I need libxml2".
3. I have nothing against better fix, but due to p. 2, did what configure script wants. And, as visible in commit log, slightly changed variation of my patch landed tree.

Anyway, thanks for the fix.