Bug 273789 - textproc/libxml2: fix build with lld 17
Summary: textproc/libxml2: fix build with lld 17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks: 273753
  Show dependency tree / graph
 
Reported: 2023-09-14 17:06 UTC by Dimitry Andric
Modified: 2023-09-16 07:14 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

Attachments
textproc/libxml2: fix build with lld 17 (1.03 KB, patch)
2023-09-14 17:06 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2023-09-14 17:06:29 UTC 
Many symbols in the linker version script libxml2.syms are only defined
when --with-xptr-locs is enabled at configure time. Since version
scripts do not support conditionals, suppress errors with lld >= 17 due
to these undefined symbols.

Note that upstream fixed this in their configure.ac in https://gitlab.gnome.org/GNOME/libxml2/-/commit/a8fe4900b, but these changes will only arrive in 2.12.0.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-09-14 17:06:58 UTC 
Created attachment 244846 [details]
textproc/libxml2: fix build with lld 17
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2023-09-15 08:59:34 UTC 
@dim, please feel free to just commit your changes to desktop@ and kde@ ports with a blanket approval.
Thanks for the work!


mfg Tobias
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-09-15 13:28:13 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b259f84ad7999066d9c85b5fcba3fbcb29d41915

commit b259f84ad7999066d9c85b5fcba3fbcb29d41915
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-09-14 17:04:19 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-09-15 13:25:49 +0000

    textproc/libxml2: fix build with lld 17

    Many symbols in the linker version script libxml2.syms are only defined
    when --with-xptr-locs is enabled at configure time. Since version
    scripts do not support conditionals, suppress errors with lld >= 17 due
    to these undefined symbols.

    PR:             273789
    MFH:            2023Q3
    Approved by:    blanket (for desktop and kde)

 textproc/libxml2/Makefile | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)