Bug 273808 - x11/jbxvt updating download location, added xcb-util-cursor dependency
Summary: x11/jbxvt updating download location, added xcb-util-cursor dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-15 01:09 UTC by pyrus
Modified: 2023-09-17 15:35 UTC (History)
2 users (show)

See Also:


Attachments
updated download location, added xcb-util-dependency (130.05 KB, patch)
2023-09-15 01:09 UTC, pyrus
no flags Details | Diff
updated download location, added xcb-util-dependency (1.55 KB, patch)
2023-09-15 01:21 UTC, pyrus
pyrus: maintainer-approval+
Details | Diff
Adjusted. Moved dependency to RUN_DEPENDS=, adjusted name in patch. (1.50 KB, patch)
2023-09-16 01:33 UTC, pyrus
pyrus: maintainer-approval-
Details | Diff
adjusted patch (1.59 KB, patch)
2023-09-16 04:46 UTC, pyrus
pyrus: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pyrus 2023-09-15 01:09:04 UTC
Created attachment 244861 [details]
updated download location, added xcb-util-dependency

Added PORTREVISON to update it to 1

Changed download location to https://github.com/alisabedard/jbxvt

Added libxcb-cursor.so:x11/xcb-util-cursor to LIB_DEPENDS

Ran new make makesum for updated distinfo
Comment 1 pyrus 2023-09-15 01:11:04 UTC
I have to do this over, the directory was correct, stuff got added, which wasn't needed
Comment 2 pyrus 2023-09-15 01:21:35 UTC
Created attachment 244862 [details]
updated download location, added xcb-util-dependency

Changed download location in Github from jefbed to alisabedard.
Updated PORTREVISION
Added xcb-util-cursor dependency
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-09-15 01:53:41 UTC
The commit says your name is "Chalie Root."  Are you sure you want to be credited under this name?
Comment 4 pyrus 2023-09-15 03:33:58 UTC
It doesn't matter. I can change it for next time.
Comment 5 pyrus 2023-09-15 03:39:56 UTC
That was the default name of the root of the jail. The credit name doesn't matter, I'll fix it for next time.

The newer patch is good. The previous commit was for the older attempted patch.
Comment 6 pyrus 2023-09-16 01:33:56 UTC
Created attachment 244912 [details]
Adjusted. Moved dependency to RUN_DEPENDS=, adjusted name in patch.

Adjusted. Moved dependency to RUN_DEPENDS. Adjusted name in patch.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-09-16 02:13:18 UTC
Why is libxcb-cursor.so:x11/xcb-util-cursor now in RUN_DEPENDS?
Comment 8 pyrus 2023-09-16 04:25:38 UTC
(In reply to Robert Clausecker from comment #7)
It's referenced in the Makefile https://github.com/alisabedard/jbxvt/blob/master/Makefile
ldflags+=-lxcb -lxcb-keysyms -lxcb-cursor

There were xcb cursor calls., but not one for the specific library. I thought it would be a runtime.

I had it right the first time. It wasn't needed for building the port, and it was for runtime. Now I see that, libraries are different than build and runtime dependencies.

I thought it built in my jail, but it doesn't build on my host system, with it as a runtime. It was right as a library depends.
Comment 9 Robert Clausecker freebsd_committer freebsd_triage 2023-09-16 04:29:35 UTC
(In reply to pyrus from comment #8)

Okay.  I'll go ahead with the original patch then (after fixing the user name).
Comment 10 pyrus 2023-09-16 04:46:52 UTC
Created attachment 244915 [details]
adjusted patch

Here it is, original with name corrected.

Sorry about that. I saw your post. I was working on this. Either way.
Comment 11 commit-hook freebsd_committer freebsd_triage 2023-09-17 15:31:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=49d8d5294950e483c3da3edcfb028fa71491b0d2

commit 49d8d5294950e483c3da3edcfb028fa71491b0d2
Author:     Pyrus <pyrus@bsdmail.com>
AuthorDate: 2023-09-15 01:16:19 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-09-17 15:23:14 +0000

    x11/jbxvt: Updated download location, added xcb-util-cursor dependency

    PR:             273808

 x11/jbxvt/Makefile | 10 ++++++----
 x11/jbxvt/distinfo |  6 +++---
 2 files changed, 9 insertions(+), 7 deletions(-)
Comment 12 Robert Clausecker freebsd_committer freebsd_triage 2023-09-17 15:35:08 UTC
Thank you for your contribution.