Bug 273873 - games/0ad: Fails to build with fmt 10+
Summary: games/0ad: Fails to build with fmt 10+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks: 273463
  Show dependency tree / graph
 
Reported: 2023-09-17 06:12 UTC by Daniel Engberg
Modified: 2023-09-18 07:22 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2023-09-17 08:29:59 UTC 
Hi!

Thanks for reporting this.

Looks like upstream already has a fix:

https://trac.wildfiregames.com/changeset/27657/ps/trunk/source/network/NetMessage.cpp

I cannot test this right away, will do that later and report back.

If everything works fine I'll commit a fix once done with testing.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-09-17 21:08:06 UTC 
Great, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-09-18 07:18:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bee4aa6a98e9d2aa673af6ec0606f88c65fd52ea

commit bee4aa6a98e9d2aa673af6ec0606f88c65fd52ea
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2023-09-18 07:16:49 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2023-09-18 07:16:49 +0000

    games/0ad: Fix build with newer libfmt

    Import upstream patch to fix building with upcoming libfmt update.

    While here, remove some unneeded dependencies.

    PR:             273873
    Obtained from:  https://trac.wildfiregames.com/changeset/27657

 games/0ad/Makefile                                     | 16 +++++++---------
 .../files/patch-source_network_NetMessage.cpp (new)    | 18 ++++++++++++++++++
 ...imulation2_serialization_BinarySerializer.cpp (new) | 11 +++++++++++
 3 files changed, 36 insertions(+), 9 deletions(-)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2023-09-18 07:22:02 UTC 
Imported upstream patch.

Thanks again for reporting.